Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the simple editor, add functionality for deleting questions. #3016

Closed
hchandad opened this issue Feb 2, 2017 · 13 comments
Closed

In the simple editor, add functionality for deleting questions. #3016

hchandad opened this issue Feb 2, 2017 · 13 comments
Assignees
@ashish3805
Labels
frontend important

Comments

@hchandad
Copy link
Contributor

hchandad commented Feb 2, 2017

Currently the simple editor doesn't implement a delete functionality, Steps to do this (all of which much be completed in the same PR)

  • (i): Add an Edit button to switch the sidebar mode from read-only to editable.
  • (ii): In edit mode, list only the question group headers without the sub items.
  • (iii): In edit mode, add an icon to each question header element for deleting it, when
    that icon is clicked, call a DeleteQuestion method in SimpleEditorManagerService.js (which changes the destination of 'correct answer' group of the source state to its new value, and then calls deleteState in SimpleEditorShimService.js to delete unused state).

See mocks for design of the sidebar in the navigation folder.
@hchandad hchandad self-assigned this Feb 2, 2017
@hchandad hchandad mentioned this issue Feb 2, 2017
Closed
@hchandad hchandad mentioned this issue Feb 2, 2017
Closed
@seanlip
Copy link
Member

seanlip commented Feb 2, 2017

Note: this should be done on the simple-editor branch, not develop.

@seanlip seanlip modified the milestone: Recommended projects Feb 3, 2017
@kevinlee12
Copy link
Contributor

Hi @andromfins, any updates regarding this issue? thanks!

@hchandad
Copy link
Contributor Author

I am still on it, will update soon.

@kevinlee12
Copy link
Contributor

sg, thanks!

@anthkris
Copy link
Contributor

Hiya @andromfins Pinging you again. Have you been able to make any progress?

@hchandad
Copy link
Contributor Author

I got this part working, i am also working on #3017 planning to submit a PR for major simple editor sidebar issues, sorry for the delay.

@anthkris
Copy link
Contributor

Thanks for the update!

@anmolshkl
Copy link
Contributor

@andromfins are you still working on this issue?

@ashish3805 ashish3805 self-assigned this May 29, 2017
@kevinlee12
Copy link
Contributor

Hi @ashish3805, any updates on this issue? thanks!

@ashish3805
Copy link

ashish3805 commented Jun 14, 2017 via email

@kevinlee12
Copy link
Contributor

thanks @ashish3805!

@ashish3805 ashish3805 mentioned this issue Jun 15, 2017
Merged
kevinlee12 pushed a commit that referenced this issue Jun 29, 2017
@ashish3805 @kevinlee12
Fix #3016: edit mode service and delete functionality for simple edit…
4c36ec5 
…or sidebar. (#3547)

* Deletion wrking, first Question can't be deleted. Basic edit mode done.

* functionality done, edit mode service created

* fixed newline error

* unit tests and spelling correction

* corrected review issues

* resolved review issues

* changed some to for in QuestionList and improved comment in Manager Service

* added test for remove question in domain, applied review suggestions.

* simplified remove question test

* resolved review issue, scroll pending

* added scrolling, improved test for remove question.
@jacobdavis11
Copy link
Member

@ashish3805 It looks like the PR is merged, so is this issue complete now?

@ashish3805
Copy link

ashish3805 commented Jul 17, 2017 via email

@seanlip seanlip closed this as completed Jul 17, 2017
@seanlip seanlip removed this from the Recommended projects milestone Jul 20, 2017
@seanlip seanlip removed this from the Recommended projects milestone Jul 20, 2017
ctao5660 pushed a commit to ctao5660/oppia that referenced this issue Nov 23, 2018
@ashish3805 @kevinlee12
Fix oppia#3016: edit mode service and delete functionality for simple…
68ee856 
… editor sidebar. (oppia#3547)

* Deletion wrking, first Question can't be deleted. Basic edit mode done.

* functionality done, edit mode service created

* fixed newline error

* unit tests and spelling correction

* corrected review issues

* resolved review issues

* changed some to for in QuestionList and improved comment in Manager Service

* added test for remove question in domain, applied review suggestions.

* simplified remove question test

* resolved review issue, scroll pending

* added scrolling, improved test for remove question.
seanlip pushed a commit that referenced this issue Sep 23, 2021
@jcqli
Fix android #3016 Create domain object, domain services, cron scrubbe…
14189cd 
…r, and controller for receiving feedback reports (#12367)

* Fix test bugs

* Add tests to shards

* Fix linter errors

* Apply review comments

* Apply review comments

* Add test to shard

* Reduce export data and update tests

* Fix linter errors

* Add validator for report model

* Fix linter errors

* Fix linter errors

* Use services to scrub report in job

* Add state_tracking_date validation test

* Add state_tracking_date validation test

* Fix stats validator test

* Fix stats validator test

* Add test that reduce() is None

* Fix incorrectly named tests

* Fix linter errors

* Address review comments, add non-empty web dict test for scrubbing

* Apply review comments

* Change device locale code to specify android

* Fix linter errors

* Clarify docstring

* Use constant for 90 days

* Add check and test to not scrub already scrubbed reports

* Use isNotNone

* Add test case for no models in storage

* Update test names

* Add helpers for tests

* Add test that checks scrubbs again on newly-added models

* Rename scrubber bot

* Remove services that manipulate model entities

* Remove service test from shard

* Add services and domain objects

* Start handler and controllers

* Create domain object form model entity

* Add domain validation for feedback report and user supplied feedback

* Add validators

* Use timestamp instead of second, fix docstring to use isoformat

* Add minimum schema value, use isoformat instead of timestamp or seconds

* Add repo name field to tickets, add total reports field to stats

* Change stats schema constant name

* Fix linter errors

* Use msec instead of isoformat for ids

* Use base64 for timestamp

* Fix linter errors

* Use int for ids

* Clarify test names

* Use isoformat for date and apply review comments

* Remove unused util function

* Add assertion to test

* Don't use map reduce to scrub reports

* Address review comments

* Validate schema on range of values

* Validate timestamps with a buffer

* Address review comments

* Add tests for deleted external references

* Add buffer to date validation

* Sort imports

* Fix linter errors

* Fix docstring typo

* Fix constant name

* Fix spacing

* Remove datetime buffer from stats date validation and newest report validation

* Update tests to validate not against any buffered datetimes

* Fix linter errors

* Clarify submitted_on field

* Add all domain object validators

* Add platform to model'

* Work on domain objects

* Specify scrubber when scrubbing all reports

* Add service tests to codeowners

* [skip ci] Fix typo

* Separate generate_id into public function

* Construct app feedback report domain object

* Create new report and stats entities in storage

* [skip ci] Fetch filters

* Add stats in transaction

* [skip ci] Save reports to storage

* Handle changing tickets

* Save all ticket attributes

* [skip ci] Update report, ticket, and stats when tickets are reassigned

* [skip ci] Fix imports

* [skip ci] Fix build errors, typos

* [skip ci] Fix build errors and typos

* [skip ci] Add domain validation errors to validator tests

* Include domain validation for all report model tests

* Include domain validation for all ticket model tests

* Include domain validation for statst model tests

* Add domain test

* Make new file for constants, write domain tests for report, device context

* Add domain tests for stats objects

* Add ticket domain tests

* Start tests for stats counts and filter domain

* [skip ci] Fix typo

* [skip ci] Fix domain objec tests, add some service tests, put all constants together

* [skip ci] Domain tests pass

* Add test for new stats and for incoming reports

* [skip ci] Finish all domain tests

* [skip ci] Fix build and test errors

* Add timezone offset field to model

* Fix test errors

* [skip ci] Add controller tests

* Fix linter errors

* [skip ci] Update category names

* [skip ci] Add tests to shards

* [skip ci] Debug test error

* Revert "[skip ci] Merge remote-tracking branch 'upstream/develop' into create-android-feedback-reporting-scrubbing-cron-job"

This reverts commit a96f790, reversing
changes made to b8cdbd3.

* Use str-type for controller test headers

* [skip ci] Resolve merge conflicts?

* [skip ci] Revert "Revert "[skip ci] Merge remote-tracking branch 'upstream/develop' into create-android-feedbacking-reporting-scrubbing-cron-job
This reverts commit 16abb5c.

* [skip ci] Push to update PR, check for conflicts

* [skip ci] Fix lint errors, pushing to update oppiabot check

* [skip ci] Fix lint errors, pushing to update oppiabot check

* [skip ci] Fix linter errors

* Fix linter errors

* [skip ci] Fix enum checks in test, pushing to update oppiabot

* Fix tests with enum types

* [skip ci] Fix domain tests with enums

* Fix test errors

* [skip ci] Fix service tests

* [skip ci] Use enum types in domain objects

* Calculate network enum from storage model

* Use enums in domain objects

* Fix linter errors, add test for g getting unscrubbed reports

* Fix linter errors

* Remove prod validators test from backend shards

* Convert string to enum for report category

* Fix validator test errors

* Add test coverage

* Fix linter errors

* Fix linter errors

* Fix typo

* Fix test bug

* Code coverage

* Fix bugs in reticketing

* Fix linter errors

* Fix linter errors

* Remove mapreduce validators

* Add URL schema validators for controllers

* Add function types for domain objects, services, controller, & tests

* Fix mypy error

* Fix linter error

* Fix mypy errors

* Fix mypy errors, add optional Nones to JSON

* Fix syntax of function type declaration

* Add schema for controller

* Fix mypy error

* Add platform check while parsing reports from dict

* Fix mypy errors

* Fix mypy errors

* Fix mypy errors

* Fix linter errors

* Fix some mypy errors and domain test

* More mypy errors

* Add test coverage

* Fix mypy errors

* Fix test bug with scrubbing reports

* Update test and fix mypy errors

* Add test coverage

* Add test coverage

* Fix mypy errors

* Add test coverage

* Fix import errors

* Reverse timestamp order in service test

* Add comment

* Update codeowners and add scrubber bot to system_users map

* Update cron test to use curriculum admin email

* Address review comments

* Address review comments

* Fix type annotations

* Add test coverage

* Fix comment

* Change max => maximum

* Remove pylint disable for __future__ imports

* Move Incoming android report URL to android validation constants

* Remove maximum android package version check

* Address review comments to validate multiple app version names and version codes

* Update app version and app code checks

* Fix mypy type annotatiosn

* Fix python 3 errors

* Fix linter errors

* Update controller name

* Add acl_decorator tests, remove unused constant

* Fix mypy errors

* Fix mypy errors

* Fix lint error

* Fix type errors

* Remove unused import

* Fix backend types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashish3805 ashish3805

Labels
frontend important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevinlee12 @anmolshkl @ashish3805 @seanlip @anthkris @hchandad @jacobdavis11