Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10385: Initialize directiveSubscriptions in music notes interaction directive #10411

Conversation

kevintab95
Copy link
Member

Overview

  1. This PR fixes or fixes part of Music interaction doesn't work #10385.
  2. This PR does the following:
  • Initialize directiveSubscriptions in music notes interaction directive

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Aug 21, 2020

Assigning @aks681 for the first-pass review of this pull request. Thanks!

@kevintab95 kevintab95 linked an issue Aug 21, 2020 that may be closed by this pull request
@vojtechjelinek vojtechjelinek changed the title Initialize directiveSubscriptions in music notes interaction directive Fix #10385: Initialize directiveSubscriptions in music notes interaction directive Aug 22, 2020
Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from code owner's perspective. Thanks!

@oppiabot
Copy link

oppiabot bot commented Aug 24, 2020

Hi @kevintab95. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@aks681 aks681 assigned kevintab95 and unassigned aks681 Aug 24, 2020
@kevintab95
Copy link
Member Author

Looks like #10395 already fixed this. Thanks @orthodoxparadox!

@kevintab95 kevintab95 closed this Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Music interaction doesn't work
3 participants