Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #9749: Migrate Oppia footer directive. #13003

Merged
merged 11 commits into from
Jun 11, 2021

Conversation

ashutoshc8101
Copy link
Contributor

Overview

  1. This PR fixes part of Migrate directives/controllers to Angular components #9749.
  2. This PR does the following: Migrate oppia footer directive.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

oppia-footer-2021-06-07_02.38.14.mp4

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@oppiabot
Copy link

oppiabot bot commented Jun 6, 2021

Hi, @ashutoshc8101, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR pointers. Assigning @ashutoshc8101 to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@ashutoshc8101
Copy link
Contributor Author

@srijanreddy98 Please take the first pass and assign the code owners once approved.

@oppiabot
Copy link

oppiabot bot commented Jun 7, 2021

Hi @ashutoshc8101. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jun 8, 2021

Hi @ashutoshc8101. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@srijanreddy98
Copy link
Member

@oppiabot
Copy link

oppiabot bot commented Jun 10, 2021

Unassigning @srijanreddy98 since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Jun 10, 2021

Assigning @vojtechjelinek, @kevintab95, @nithusha21, @DubeySandeep, @jameesjohn, @darksun27 for code owner reviews. Thanks!

Copy link
Contributor

@darksun27 darksun27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oppiabot
Copy link

oppiabot bot commented Jun 10, 2021

Unassigning @darksun27 since they have already approved the PR.

Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowner files

@oppiabot
Copy link

oppiabot bot commented Jun 10, 2021

Unassigning @nithusha21 since they have already approved the PR.

Copy link
Member

@kevintab95 kevintab95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowner files. Thanks @ashutoshc8101!

@kevintab95 kevintab95 removed their assignment Jun 10, 2021
Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oppiabot
Copy link

oppiabot bot commented Jun 11, 2021

Hi @ashutoshc8101. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@ashutoshc8101 ashutoshc8101 enabled auto-merge (squash) June 11, 2021 15:16
@ashutoshc8101 ashutoshc8101 merged commit dc58e8d into oppia:develop Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants