-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Part of #10474: Enables strict typescript checks for some files - (6) #13135
Conversation
some title
merged-with-develop
Unassigning @kevintab95 since they have already approved the PR. |
Hi @mridul-netizen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Unassigning @srijanreddy98 since they have already approved the PR. |
Unassigning @darksun27 since they have already approved the PR. |
@DubeySandeep PTAL |
@@ -22,7 +22,8 @@ | |||
import { LoggerService } from 'services/contextual/logger.service'; | |||
|
|||
export class Stopwatch { | |||
startTime; | |||
// Start time is null initially . | |||
startTime: number | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's not the startTime, right? Also, I'm not sure how the service is used if the startTime is set to null in the constructor? Do you see any use case of setting startTime to null in the constructor?
Unassigning @DubeySandeep since the review is done. |
Hi @mridul-netizen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
Unassigning @DubeySandeep since they have already approved the PR. |
Hi @mridul-netizen, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Overview
Essential Checklist
Proof that changes are correct
PR Pointers
Files Covered
PasteBin to Errors - link