Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate MockTranslatePipe from Unit-test.utils.ts #13149

Merged
merged 54 commits into from
Jun 28, 2021

Conversation

mridul-netizen
Copy link
Contributor

@mridul-netizen mridul-netizen commented Jun 20, 2021

Overview

  1. This PR fixes or fixes part of #NA.
  2. This PR does the following: Separates MockTranslatePipe from unit-test-utils.ts

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Design Doc for the changes:

https://docs.google.com/document/d/1eyqjf-pecEatjLsGxQb5DBfCGnTIAjsXl3QViVS1R8c/edit?usp=sharing

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@oppiabot
Copy link

oppiabot bot commented Jun 23, 2021

Unassigning @DubeySandeep since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Jun 26, 2021

Unassigning @nithusha21 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Jun 26, 2021
@oppiabot
Copy link

oppiabot bot commented Jun 26, 2021

Hi @mridul-netizen, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jun 28, 2021

Unassigning @srijanreddy98 since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Jun 28, 2021

Hi @mridul-netizen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@oppiabot oppiabot bot removed PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. PR: don't merge - HAS MERGE CONFLICTS labels Jun 28, 2021
Copy link
Member

@kevintab95 kevintab95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowner files. Thanks @mridul-netizen!

@kevintab95 kevintab95 removed their assignment Jun 28, 2021
@mridul-netizen mridul-netizen merged commit fc11de3 into oppia:develop Jun 28, 2021
@mridul-netizen mridul-netizen deleted the unit-tests branch June 28, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants