Fix Part of #10474: Enables strict typescript checks for some files - (8)

[mridul-netizen]

Overview

1. This PR fixes or fixes part of Make typescript checks strict #10474 .
2. This PR does the following: [Make Typescript checks strict for some files]

Essential Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The linter/Karma presubmit checks have passed locally on your machine.
• "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • This lets reviewers restart your CircleCI tests for you.
• The PR is made from a branch that's not called "develop".

Proof that changes are correct

PR Pointers

• Make sure to follow the instructions for making a code change.
• Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
• For what code owners will expect, see the Code Owner's wiki page.
• Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
• Never force push. If you do, your PR will be closed.
• Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
• Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

Files Covered

    "core/templates/domain/statistics/PlaythroughObjectFactory.ts",
    "core/templates/domain/statistics/PlaythroughObjectFactorySpec.ts",
    "core/templates/domain/platform_feature/platform-feature-admin-backend-api.service.ts",
    "core/templates/domain/platform_feature/platform-feature-admin-backend-api.service.spec.ts",
    "core/templates/domain/improvements/improvements.constants.ts",
    "core/templates/domain/exploration/visualization-info.model.ts",
    "core/templates/domain/exploration/visualization-info.model.spec.ts",
    "core/templates/domain/email-dashboard/email-dashboard-backend-api.service.ts",
    "core/templates/domain/email-dashboard/email-dashboard-backend-api.service.spec.ts",
    "core/templates/domain/platform_feature/platform-parameter.model.ts",
    "core/templates/domain/platform_feature/platform-parameter.model.spec.ts",
    "extensions/rich_text_components/Tabs/directives/oppia-noninteractive-tabs.component.ts",
    "extensions/rich_text_components/Collapsible/directives/oppia-noninteractive-collapsible.component.ts",
    "extensions/objects/templates/position-of-terms-editor.component.ts",
    "extensions/objects/templates/position-of-terms-editor.component.spec.ts",
    "extensions/objects/templates/music-phrase-editor.component.ts",
    "extensions/interactions/GraphInput/directives/oppia-short-response-graph-input.component.ts",
    "extensions/interactions/GraphInput/directives/oppia-response-graph-input.component.ts",
    "core/templates/services/auth.service.ts",
    "core/templates/services/auth.service.spec.ts",
    "core/templates/filters/string-utility-filters/wrap-text-with-ellipsis.pipe.ts",
    "core/templates/filters/string-utility-filters/wrap-text-with-ellipsis.pipe.spec.ts",
    "core/templates/services/stateful/focus-manager.service.ts",
    "core/templates/services/stateful/focus-manager.service.spec.ts",
    "core/templates/domain/topics_and_skills_dashboard/topics-and-skills-dashboard-filter.model.ts",
    "core/templates/domain/topics_and_skills_dashboard/topics-and-skills-dashboard-filter.model.spec.ts",
    "core/templates/domain/story/story-summary.model.ts",
    "core/templates/domain/story/story-summary.model.spec.ts",

PasteBin to Errors - link

[oppiabot]

Hi @mridul-netizen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

[srijanreddy98]

Just a follow up to @kevintab95's comment otherwise LGTM

[srijanreddy98]

Do we throw errors in get methods in models normally? We expect validation methods to do these checks and report errors in the appropriate place.

I think it's fine to keep validation here. If this skips some sort of validation and ends up here, we would want to know. But, this should not be here in a getter. You should do this check in the setter. (If undefined for _topicUrlFragment is not a valid value, it shouldn't be allowed to set to undefined in the first place. Can you throw an error there?)

[oppiabot]

Unassigning @srijanreddy98 since the review is done.

[kevintab95]

LGTM for core/templates/domain/exploration/visualization-info.model.ts. Thanks @mridul-netizen!

[oppiabot]

Unassigning @kevintab95 since they have already approved the PR.

[aks681]

Lgtm as codeowner

[oppiabot]

Hi @mridul-netizen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

[mridul-netizen]

@iamprayush @srijanreddy98 PTAL

[iamprayush]

LGTM for code-owner files!