-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refractors UrlInterpolationService to not return null at interpolateUrl #13371
Conversation
some title
merged-with-develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thankyou @mridul-netizen
Unassigning @EeshaArif since they have already approved the PR. |
Assigning @nithusha21, @DubeySandeep for code owner reviews. Thanks! |
@nithusha21 @DubeySandeep PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Unassigning @nithusha21 since they have already approved the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mridul-netizen Thanks a lot for this fix, I've left one minor comment, PTAL!
if (!urlTemplate) { | ||
this.alertsService.fatalWarning( | ||
'Invalid or empty URL template passed in: \'' + urlTemplate + '\''); | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we expecting to stop the function execution here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed the above comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a code comment explaining the same. ALso, can you confirm that we have a unit test to ensure that the function execution stops after line 121?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unassigning @DubeySandeep since the review is done. |
@DubeySandeep PTAL! |
Unassigning @DubeySandeep since they have already approved the PR. |
Hi @mridul-netizen, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Overview
Essential Checklist
PR Pointers