Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14692: Saving changes to a story without a commit message results in an error #14722

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

Lawful2002
Copy link
Contributor

@Lawful2002 Lawful2002 commented Jan 20, 2022

Overview

  1. This PR fixes Saving changes to a story without a commit message results in an error #14692.
  2. This PR does the following: Fixed the spelling of [disabled]

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

oppia-modal.mp4

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@oppiabot
Copy link

oppiabot bot commented Jan 20, 2022

Hi, @Lawful2002, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR pointers. Assigning @Lawful2002 to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

Copy link
Contributor

@Rijuta-s Rijuta-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lawful2002! LGTM.

@oppiabot
Copy link

oppiabot bot commented Jan 20, 2022

Assigning @EricZLou for code owner reviews. Thanks!

Copy link
Contributor

@EricZLou EricZLou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@EricZLou EricZLou enabled auto-merge (squash) January 21, 2022 22:35
@oppiabot oppiabot bot unassigned EricZLou Jan 21, 2022
@oppiabot
Copy link

oppiabot bot commented Jan 21, 2022

Unassigning @EricZLou since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jan 21, 2022
@oppiabot
Copy link

oppiabot bot commented Jan 21, 2022

Hi @aks681, this PR is ready to be merged. Author of this PR does not have permissions to merge this PR. Before you merge it, please make sure that there are no pending comments that require action from the author's end. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving changes to a story without a commit message results in an error
6 participants