Fix #14698: Add ability to generate X sample translation opportunities on local dev server #14889

jimbyo · 2022-02-09T09:11:54Z

Overview

This PR adds a generate translation opportunities button in the admin.py
You can select the number of opportunities and number of interactions in each opportunity to generate

Essential Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The linter/Karma presubmit checks have passed locally on your machine.
"Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
- This lets reviewers restart your CircleCI tests for you.
The PR is made from a branch that's not called "develop".

Proof that changes are correct

Video

Creates 10 opportunities with 10 interactions
Checks Contributor dashboard
Creates 10 opportunities with 1 interaciton
Checks Contributor dashboard

Screen.Recording.2022-02-15.at.4.22.51.PM.mov

Video 2

Creates 1 opportunities with 1 interactions without checked submit suggestions.
Checks Contributor dashboard
Creates 1 opportunities with 1 interactions with checked submit suggestion.
Checks Contributor dashboard noticing 4 submitted suggestions
Creates 5 opportunities with 5 interactions with checked submit suggestion.
Checks Contributor dashboard noticing 104 submitted suggestions

Screen.Recording.2022-02-23.at.6.00.45.PM.mov

…also make opportunity list hidden when LoadingMoreData

…y-loading

oppiabot · 2022-02-09T09:11:55Z

Hi @jimbyo, can you complete the following:

The body of this PR is missing the required description, please update the body with a description of what this PR does.
The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing.
The proof that changes are correct has not been provided, please make sure to upload a image/video showing that the changes are correct. Or include a sentence saying "No proof of changes needed because" and the reason why proof of changes cannot be provided.
Thanks!

oppiabot · 2022-02-09T09:12:07Z

Hi @nithusha21, @DubeySandeep -- could one of you please add the appropriate changelog label to this pull request? Thanks!

oppiabot · 2022-02-09T09:43:35Z

Hi @jimbyo. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

jimbyo · 2022-02-09T23:59:28Z

Closing for now because of bugs when generating opportunities multiple times

oppiabot · 2022-02-16T00:13:53Z

Hi @jimbyo, can you complete the following:

The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing.
The proof that changes are correct has not been provided, please make sure to upload a image/video showing that the changes are correct. Or include a sentence saying "No proof of changes needed because" and the reason why proof of changes cannot be provided.
Thanks!

oppiabot · 2022-03-02T04:03:56Z

Hi @jimbyo, it looks like some changes were requested on this pull request by @sagangwee. PTAL. Thanks!

oppiabot · 2022-03-09T04:14:38Z

Hi @jimbyo, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot · 2022-03-09T11:14:42Z

Hi @jimbyo, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

…y-loading

jimbyo

Took another pass! PTAL! @sagangwee

jimbyo · 2022-03-20T18:14:47Z

core/controllers/admin.py

+            elif action == 'generate_sample_opportunities':
+                num_sample_ops = self.normalized_payload.get(
+                    'num_sample_ops')
+                num_sample_interactions = self.normalized_payload.get(


jimbyo · 2022-03-20T18:16:59Z

core/controllers/admin.py

+        Args:
+            num_sample_ops: int. Count of sample opportunities to
+                be generated.
+            num_sample_interactions: int. Count of sample


jimbyo · 2022-03-20T18:19:12Z

core/controllers/admin.py

+                be generated.
+            num_sample_interactions: int. Count of sample
+                interactions to be generated.
+            should_submit_suggestions: boolean. Boolean to track


jimbyo · 2022-03-20T18:22:54Z

core/controllers/admin.py

+            should_submit_suggestions: boolean. Boolean to track
+                whether suggestions should be submitted.
+        """
+        topic_id_1 = topic_fetchers.get_new_topic_id()


changed to topic id and also changed topic_1 to topic

jimbyo · 2022-03-20T18:44:35Z

core/controllers/admin.py

+            story_id, exp_ids_in_story)
+
+        if should_submit_suggestions:
+            for i in range(num_sample_ops):


done. Changed i to opportunity_num and j to interaction num

jimbyo · 2022-03-20T21:40:06Z

core/controllers/admin.py

+                new_exploration_id, title=title, category=category,
+                objective='Dummy Objective')
+
+            for interaction_num in range(num_sample_interactions):


created helper

jimbyo · 2022-03-20T21:42:46Z

core/controllers/admin.py

+                objective='Dummy Objective')
+
+            for interaction_num in range(num_sample_interactions):
+                if interaction_num == num_sample_interactions - 1:


Done!

Also quick question. When should we have helper functions inside a function and outside a function

core/controllers/admin.py

jimbyo · 2022-03-20T21:46:12Z

core/controllers/admin.py

+        len_story = len(story_node_dicts)
+        for i, story_node_dict in enumerate(story_node_dicts):
+            self._generate_sample_story_nodes(
+                story, len_story, i + 1, **story_node_dict)


story node ids start at one not zero, when they start at zero the code fails. I have changed enumerate(story_node_dicts) to enumerate(story_node_dicts, 1) to make this more clear than the previous i + 1

jimbyo · 2022-03-21T02:42:37Z

core/controllers/admin.py

+        """
+
+        story.add_node(
+            '%s%d' % (story_domain.NODE_ID_PREFIX, node_id),


Sorry what are you talking being duplicated? This portion?
'%s%d' % (story_domain.NODE_ID_PREFIX, node_id)

oppiabot · 2022-03-23T22:22:34Z

Hi @jimbyo, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

sagangwee

@jimbyo Sorry for the delay! Took a pass. Thanks.

sagangwee · 2022-03-24T21:35:04Z

core/controllers/admin.py

+                Track whether suggestions should be submitted.
+
+        Raises:
+            Exception. Environment is not DEVMODE.


sagangwee · 2022-03-24T21:35:19Z

core/controllers/admin.py

+            num_sample_interactions_per_opportunity: int. Number of sample
+                interactions to generate per opportunity.
+            should_submit_suggestions: boolean.
+                Track whether suggestions should be submitted.


Cam omit "Track"

sagangwee · 2022-03-24T21:36:39Z

core/controllers/admin.py

+                    num_sample_interactions_per_opportunity,
+                    should_submit_suggestions)
+
+    def _generate_sample_opportunities_without_existing_topic(


Generally order functions in the order that they're used, so this should be below _generate_sample_opportunities_with_existing_topic.

sagangwee · 2022-03-24T21:37:09Z

core/controllers/admin.py

+            self, num_sample_ops,
+            num_sample_interactions_per_opportunity,
+            should_submit_suggestions):
+        """Generates a topic and story and creates


Bring some of the sentence to this line up to the line limit?

sagangwee · 2022-03-24T21:37:49Z

core/controllers/admin.py

+                interactions to generate per opportunity.
+            should_submit_suggestions: boolean.
+                Track whether suggestions should be submitted.
+            story_url_fragment: stringType. Story fragment of existing story.


*string ?

Also, what does "Story fragment of existing story" mean? The description should something like "The url fragment of the story." right? And if the story_url_fragment is always set to 'sample-story-title', then it doesn't seem like this arg is necessary.

sagangwee · 2022-03-24T21:43:13Z

core/controllers/admin.py

+                have been generated.
+            num_sample_interactions_per_opportunity: int. Number of sample
+                interactions that have been generated.
+            exp_ids_in_story: list. List of the exploration ids of explorations


Nit: Since we specify the "list" type already, we can just omit the "List of" part of the description. Here and below.

sagangwee · 2022-03-24T21:44:42Z

core/controllers/admin.py

+            title = random.choice(possible_titles) + ' ' + str(
+                opportunity_num + num_chapters)


Prefer using string interpolation instead of concatenation here (easier to read).

sagangwee · 2022-03-24T21:46:22Z

core/controllers/admin.py

+
+        for interaction_num in range(num_sample_interactions_per_opportunity):
+            if is_last_interaction():
+                dest = 'End'


Nit: destination and current_state seem short enough to not abbreviate.

sagangwee · 2022-03-24T21:46:38Z

core/controllers/admin.py

+        """Populates a sample interaction
+        and links to a destination interaction.


Fix line limit here as well.

sagangwee · 2022-03-24T21:48:49Z

core/controllers/admin.py

+        """
+
+        story.add_node(
+            '%s%d' % (story_domain.NODE_ID_PREFIX, node_id),


Yeah. It would read better if we stored that portion to a variable, e.g. node_name.

oppiabot · 2022-03-24T21:52:22Z

Unassigning @sagangwee since the review is done.

oppiabot · 2022-03-24T21:52:25Z

Hi @jimbyo, it looks like some changes were requested on this pull request by @sagangwee. PTAL. Thanks!

oppiabot · 2022-03-25T15:05:28Z

Hi @jimbyo, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

oppiabot · 2022-04-01T15:31:56Z

Hi @jimbyo, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

jimbyo added 10 commits December 1, 2021 12:20

change LoadingMoreData to always equal to true at the start ngoinit, …

6a77f51

…also make opportunity list hidden when LoadingMoreData

fix lints

2176f3e

fix nit

e644427

Merge branch 'develop' of https://github.com/oppia/oppia into add-laz…

70f942f

…y-loading

Merge branch 'develop' of https://github.com/oppia/oppia into add-laz…

4797f8b

…y-loading

create opportunity generation button

980929a

fix lints

3a21e8b

fix lints

2683a64

add fail cases

bf21e85

fix indent

dc06c2a

jimbyo requested review from DubeySandeep and nithusha21 as code owners February 9, 2022 09:11

jimbyo requested a review from a team February 9, 2022 09:11

oppiabot bot assigned jimbyo Feb 9, 2022

oppiabot bot added the REVIEWERS: Please add changelog label label Feb 9, 2022

oppiabot bot assigned DubeySandeep and nithusha21 Feb 9, 2022

oppiabot bot added the PR: don't merge - HAS MERGE CONFLICTS label Feb 9, 2022

jimbyo closed this Feb 9, 2022

jimbyo added 5 commits February 10, 2022 15:30

resolve merge conflicts

1612e9e

create function _create_dummy_opportunities_with_existing_topic

1162cd4

fix_lints

6219634

fix_lints

46fade6

fix_lints

016eac9

jimbyo reopened this Feb 16, 2022

oppiabot bot assigned jimbyo Mar 2, 2022

oppiabot bot added stale PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. labels Mar 9, 2022

jimbyo added 2 commits March 10, 2022 23:55

Merge branch 'develop' of https://github.com/oppia/oppia into add-laz…

d068aa1

…y-loading

add-lazy-loading

d983cb5

oppiabot bot closed this Mar 13, 2022

Merge branch 'develop' of https://github.com/oppia/oppia into add-laz…

7975dab

…y-loading

jimbyo reopened this Mar 20, 2022

oppiabot bot removed the stale label Mar 20, 2022

third pass

7c2542f

oppiabot bot removed the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Mar 21, 2022

jimbyo added 2 commits March 20, 2022 20:32

fix spacing issues

25f86c8

revert changes on _generate_dummy_explorations

5f5e5d2

jimbyo commented Mar 21, 2022

View reviewed changes

jimbyo assigned sagangwee and unassigned jimbyo Mar 21, 2022

oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Mar 23, 2022

sagangwee suggested changes Mar 24, 2022

View reviewed changes

oppiabot bot unassigned sagangwee Mar 24, 2022

oppiabot bot assigned jimbyo Mar 24, 2022

oppiabot bot added the stale label Apr 1, 2022

oppiabot bot closed this Apr 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #14698: Add ability to generate X sample translation opportunities on local dev server #14889

Fix #14698: Add ability to generate X sample translation opportunities on local dev server #14889

jimbyo commented Feb 9, 2022 •

edited

oppiabot bot commented Feb 9, 2022

oppiabot bot commented Feb 9, 2022

oppiabot bot commented Feb 9, 2022

jimbyo commented Feb 9, 2022

oppiabot bot commented Feb 16, 2022

oppiabot bot commented Mar 2, 2022

oppiabot bot commented Mar 9, 2022

oppiabot bot commented Mar 9, 2022

jimbyo left a comment

jimbyo Mar 20, 2022

jimbyo Mar 20, 2022

jimbyo Mar 20, 2022

jimbyo Mar 20, 2022

jimbyo Mar 20, 2022

jimbyo Mar 20, 2022

jimbyo Mar 20, 2022

jimbyo Mar 20, 2022 •

edited

jimbyo Mar 21, 2022

oppiabot bot commented Mar 23, 2022

sagangwee left a comment

sagangwee Mar 24, 2022

sagangwee Mar 24, 2022

sagangwee Mar 24, 2022

sagangwee Mar 24, 2022

sagangwee Mar 24, 2022

sagangwee Mar 24, 2022

sagangwee Mar 24, 2022

sagangwee Mar 24, 2022

sagangwee Mar 24, 2022

sagangwee Mar 24, 2022

oppiabot bot commented Mar 24, 2022

oppiabot bot commented Mar 24, 2022

oppiabot bot commented Mar 25, 2022

oppiabot bot commented Apr 1, 2022

		title = random.choice(possible_titles) + ' ' + str(
		opportunity_num + num_chapters)

		"""Populates a sample interaction
		and links to a destination interaction.

Fix #14698: Add ability to generate X sample translation opportunities on local dev server #14889

Fix #14698: Add ability to generate X sample translation opportunities on local dev server #14889

Conversation

jimbyo commented Feb 9, 2022 • edited

Overview

Essential Checklist

Proof that changes are correct

oppiabot bot commented Feb 9, 2022

oppiabot bot commented Feb 9, 2022

oppiabot bot commented Feb 9, 2022

jimbyo commented Feb 9, 2022

oppiabot bot commented Feb 16, 2022

oppiabot bot commented Mar 2, 2022

oppiabot bot commented Mar 9, 2022

oppiabot bot commented Mar 9, 2022

jimbyo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jimbyo Mar 20, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oppiabot bot commented Mar 23, 2022

sagangwee left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oppiabot bot commented Mar 24, 2022

oppiabot bot commented Mar 24, 2022

oppiabot bot commented Mar 25, 2022

oppiabot bot commented Apr 1, 2022

jimbyo commented Feb 9, 2022 •

edited

jimbyo Mar 20, 2022 •

edited