Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our fork of pylint-quotes #15216

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

vojtechjelinek
Copy link
Member

Overview

  1. This PR fixes or fixes part of #N/A
  2. This PR does the following: Use our fork of pylint-quotes that has the pinned dependency to pylint

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

No proof of changes needed because this mainly fixes lint checks and passing actions should be a proof.

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@oppiabot
Copy link

oppiabot bot commented Mar 25, 2022

Assigning @DubeySandeep for the first-pass review of this pull request. Thanks!

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know when this is safe to merge!

@seanlip
Copy link
Member

seanlip commented Mar 25, 2022

Also do you need to apply the label requesting that folks update their PRs to this version?

@vojtechjelinek vojtechjelinek added the PR: require post-merge sync to HEAD Require all open pull requests to be updated after this PR get's merged label Mar 25, 2022
@seanlip
Copy link
Member

seanlip commented Mar 25, 2022

Merging to unbreak develop.

@seanlip seanlip merged commit 96a1c7a into oppia:develop Mar 25, 2022
This was referenced Mar 25, 2022
This was referenced Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: require post-merge sync to HEAD Require all open pull requests to be updated after this PR get's merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants