Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1.3 (Improve line and branch coverage for the frontend and the backend): Updated run_backend_test script to calculate per-file branch coverage #15697

Merged
merged 26 commits into from
Aug 10, 2022

Conversation

IamEzio
Copy link
Contributor

@IamEzio IamEzio commented Jul 10, 2022

Overview

  1. This PR fixes or fixes part of NA.
  2. This PR does the following:
    • Updated run_backend_tests script to calculate branch coverage
    • Adds remaining incompletely covered files to the exclusion list

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

NA

Proof of changes on desktop with slow/throttled network

NA

Proof of changes on mobile phone

NA

Proof of changes in Arabic language

NA

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@IamEzio IamEzio requested a review from a team July 10, 2022 06:30
@IamEzio IamEzio requested a review from a team as a code owner July 10, 2022 06:30
@IamEzio IamEzio marked this pull request as draft July 10, 2022 06:30
@oppiabot
Copy link

oppiabot bot commented Jul 10, 2022

Hi, @IamEzio, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR pointers. Assigning @IamEzio to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 13, 2022

Hi @IamEzio, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Jul 13, 2022
@oppiabot oppiabot bot removed the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Jul 14, 2022
@oppiabot
Copy link

oppiabot bot commented Jul 16, 2022

Hi @IamEzio, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 16, 2022

Hi @IamEzio, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Jul 17, 2022
@oppiabot
Copy link

oppiabot bot commented Jul 17, 2022

Hi @IamEzio, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 17, 2022

Hi @IamEzio, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 21, 2022

Hi @IamEzio. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 21, 2022

Hi @IamEzio, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 25, 2022

Hi @IamEzio, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 31, 2022

Hi @IamEzio, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@IamEzio
Copy link
Contributor Author

IamEzio commented Aug 7, 2022

@U8NWXD PTAL! Thanks

@oppiabot oppiabot bot assigned U8NWXD and unassigned IamEzio Aug 7, 2022
@oppiabot
Copy link

oppiabot bot commented Aug 7, 2022

Unassigning @IamEzio since a re-review was requested. @IamEzio, please make sure you have addressed all review comments. Thanks!

@U8NWXD U8NWXD assigned IamEzio and unassigned U8NWXD Aug 7, 2022
@IamEzio
Copy link
Contributor Author

IamEzio commented Aug 8, 2022

@U8NWXD PTAL! Thanks

@oppiabot oppiabot bot assigned U8NWXD and unassigned IamEzio Aug 8, 2022
@oppiabot
Copy link

oppiabot bot commented Aug 8, 2022

Unassigning @IamEzio since a re-review was requested. @IamEzio, please make sure you have addressed all review comments. Thanks!

@oppiabot
Copy link

oppiabot bot commented Aug 8, 2022

Hi @IamEzio, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

scripts/backend_test_shards.json Outdated Show resolved Hide resolved
scripts/check_overall_backend_test_coverage_test.py Outdated Show resolved Hide resolved
@U8NWXD U8NWXD removed their assignment Aug 8, 2022
@IamEzio
Copy link
Contributor Author

IamEzio commented Aug 9, 2022

@U8NWXD PTAL! Thanks

@oppiabot oppiabot bot assigned U8NWXD and unassigned IamEzio Aug 9, 2022
@oppiabot
Copy link

oppiabot bot commented Aug 9, 2022

Unassigning @IamEzio since a re-review was requested. @IamEzio, please make sure you have addressed all review comments. Thanks!

@oppiabot oppiabot bot unassigned U8NWXD Aug 9, 2022
@oppiabot
Copy link

oppiabot bot commented Aug 9, 2022

Unassigning @U8NWXD since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Aug 9, 2022

Assigning @krishnarao22 for code owner reviews. Thanks!

@U8NWXD U8NWXD merged commit 906c48f into oppia:develop Aug 10, 2022
@IamEzio IamEzio deleted the branch-coverage branch August 10, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants