Fix #15746: Don't set active topic to 'ALL' in contributor dashboard page.

core/templates/pages/contributor-dashboard-page/contributor-dashboard-page.component.spec.ts

@@ -46,6 +46,7 @@ describe('Contributor dashboard page', () => {
   };
   let focusManagerService: FocusManagerService;
   let windowRef: WindowRef;
+  let getTranslatableTopicNamesAsyncSpy;
   let getUserInfoAsyncSpy;
 
   beforeEach(waitForAsync(() => {
@@ -79,8 +80,10 @@ describe('Contributor dashboard page', () => {
     userService = TestBed.inject(UserService);
     focusManagerService = TestBed.inject(FocusManagerService);
 
-    spyOn(contributionOpportunitiesService, 'getTranslatableTopicNamesAsync')
-      .and.returnValue(Promise.resolve(['Topic 1', 'Topic 2']));
+    getTranslatableTopicNamesAsyncSpy = spyOn(
+      contributionOpportunitiesService, 'getTranslatableTopicNamesAsync');
+    getTranslatableTopicNamesAsyncSpy.and.returnValue(
+      Promise.resolve(['Topic 1', 'Topic 2']));
     spyOn(localStorageService, 'getLastSelectedTranslationLanguageCode').and
       .returnValue('');
     spyOn(localStorageService, 'getLastSelectedTranslationTopicName').and
@@ -99,7 +102,6 @@ describe('Contributor dashboard page', () => {
     spyOn(userService, 'getUserContributionRightsDataAsync')
       .and.returnValue(Promise.resolve(userContributionRights));
     getUserInfoAsyncSpy = spyOn(userService, 'getUserInfoAsync');
-
     getUserInfoAsyncSpy.and.returnValue(
       Promise.resolve(userInfo as UserInfo));
 
@@ -144,14 +146,31 @@ describe('Contributor dashboard page', () => {
   }));
 
   describe('when user is logged in', () => {
-    it('should set specific properties after $onInit is called', () => {
-      expect(component.topicName).toBe('All');
-      expect(translationTopicService.setActiveTopicName)
-        .toHaveBeenCalled();
-      expect(component.activeTabName).toBe('myContributionTab');
-      expect(component.OPPIA_AVATAR_IMAGE_URL).toBe(
-        '/assets/images/avatar/oppia_avatar_100px.svg');
-    });
+    it('should set specific properties after $onInit is called',
+      fakeAsync(() => {
+        component.ngOnInit();
+        tick();
+
+        expect(component.topicName).toBe('Topic 1');
+        expect(translationTopicService.setActiveTopicName)
+          .toHaveBeenCalled();
+        expect(component.activeTabName).toBe('myContributionTab');
+        expect(component.OPPIA_AVATAR_IMAGE_URL).toBe(
+          '/assets/images/avatar/oppia_avatar_100px.svg');
+      }));
+
+    it('should not set active topic name when no topics are returned',
+      fakeAsync(() => {
+        getTranslatableTopicNamesAsyncSpy.and.returnValue(
+          Promise.resolve([]));
+
+        component.ngOnInit();
+        tick();
+
+        expect(component.topicName).toBe(undefined);
+        expect(translationTopicService.setActiveTopicName)
+          .not.toHaveBeenCalled();
+      }));
 
     it('should return language description in kebab case format', () => {
       let languageDescription = 'Deutsch (German)';

core/templates/pages/contributor-dashboard-page/contributor-dashboard-page.component.ts

@@ -194,16 +194,17 @@ export class ContributorDashboardPageComponent
         this.profilePictureDataUrl = decodeURIComponent(dataUrl);
       });
 
-    this.topicName = (
-      ContributorDashboardConstants.DEFAULT_OPPORTUNITY_TOPIC_NAME);
-    this.translationTopicService.setActiveTopicName(this.topicName);
-
     this.contributionOpportunitiesService.getTranslatableTopicNamesAsync()
       .then((topicNames) => {
+        // TODO(#15710): Set default active topic to 'All'.
+        if (topicNames.length <= 0) {
+          return;
+        }
+        this.topicName = topicNames[0];
         if (topicNames.indexOf(prevSelectedTopicName) !== -1) {
           this.topicName = prevSelectedTopicName;
-          this.translationTopicService.setActiveTopicName(this.topicName);
         }
+        this.translationTopicService.setActiveTopicName(this.topicName);
       });
 
     this.activeTabName = 'myContributionTab';