-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hashes correctly #17223
Fix hashes correctly #17223
Conversation
Hi @vojtechjelinek please assign the required reviewer(s) for this PR. Thanks! |
Hi @vojtechjelinek, can you complete the following:
|
@vojtechjelinek is there any way to test the hashes on a separate repository? |
@gp201 I've verified it at least locally now. |
Hi @vojtechjelinek, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unassigning @gp201 since they have already approved the PR. |
Hi @vojtechjelinek, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Overview
Essential Checklist
Proof that changes are correct
Not possible to provide as the changes first need to be merged to see if they work.
PR Pointers