Implement part of #17712, #18893: Acceptance tests for translation admin users #18345

agallop · 2023-06-06T21:07:07Z

Overview

This PR implements part of Acceptance Testing - covering all the Creator's and Contributor's CUJs. #17712, [CD Acceptance Tests]: Translation Admins #18893
This PR does the following: Adds acceptance tests for translation admin users

Essential Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The linter/Karma presubmit checks have passed locally on your machine.
"Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
- This lets reviewers restart your CircleCI tests for you.
The PR is made from a branch that's not called "develop".

Proof that changes are correct

Here are some screenshots of some parts of the UI states being verified by the acceptance tests. https://drive.google.com/drive/folders/1KhmSikbNwAfYBZedG3ACre7dvGIJMVHf?usp=sharing

…troller.domain_objects_validator` to 100% (oppia#18042) * Cover domain_objects_validator line 71 & 278-287 * Cover 3 branches in domain_objects_validator Branch 125->128, 128->131, 131->149 * Cover domain_objects_validator line 213-231 * Raise errors noisily in validate_change_dict_for_blog_post * Cover domain_objects_validator line 257 * Fix the wrong function calls * Allow optional thumbnail & tags * Fix blog changes test: fields are not required * Remove domain_object_validator from tests_incomplete_coverage.txt * Apply suggestions from code review Move brackets around. Co-authored-by: Aasif Faizal <38973423+aasiffaizal@users.noreply.github.com> * fix wrong variable name and redundant deep copy --------- Co-authored-by: Aasif Faizal <38973423+aasiffaizal@users.noreply.github.com>

* Create shivkant_testing_redis.yml * reverted workflow * fixing flakes of blog editor tests * added image path constant * changed puppeteer alerts comment as issue with Chromium * changed puppeteer alerts comment as issue with Chromium * changed puppeteer alerts comment as issue with Chromium * small changes * small changes * added mock user exploration permission service * using spyOn for the mock class * Delete mock_app.yaml * Delete mock_app_dev.yaml * used the original function while mocking * used the original function while mocking

* Removed Extra Spaces in add response box * Update rule-editor.component.html --------- Co-authored-by: SUBHASH THENUA <100484672+SubhashThenua@users.noreply.github.com>

* Add CI template * minor lint fix * Minor fixes

… boolean (oppia#17964) * added another data type to the platform parameter * added one off jobs * All jobs works perfectly and have been tested on the local server * fixing lint issues * removed the jobs * fixed backend test * added a backend test that checks all the feature flags are of type bool * fixed backend test and lint * small lint fix * updated the feature-field name * removed the emulator mode check and done suggested changes * removed additional type platform-param * fixed lint * removed addition of new field

…ia#18110) * Fix exploration load before save progress modal * fix non checkpoint explorations error * event name correction

…rences page (oppia#18149) * Fixed accessibility for preferences page * Fixed lint * Update core/templates/components/common-layout-directives/navigation-bars/top-navigation-bar.component.html Co-authored-by: Rijuta Singh <68547101+Rijuta-s@users.noreply.github.com> * Fixed lighthouse * lint * fixed lighthouse * added aria --------- Co-authored-by: Rijuta Singh <68547101+Rijuta-s@users.noreply.github.com>

…on language dropdown. (oppia#18235) fixed-18230 Incorrect Description of the Hausa Language Title on language dropdown Changes made in constant.js only Halshen has changed into harshen

… option on the preferences page (oppia#18194) * Add contributor dashboard as a default dashboard option * Add test coverage for new behaviour in signup-page.component.ts * Address review comments * Fix linter errors * Address the nit Co-authored-by: Rijuta Singh <68547101+Rijuta-s@users.noreply.github.com> --------- Co-authored-by: Rijuta Singh <68547101+Rijuta-s@users.noreply.github.com>

…ppia#16584) * Frontend changes for profile photos * backend changes for profile picture and cleanup on controller and domain * edited as per the suggestion * added func to utils file * updated req files * nits * introduced job * testing * Small fixes * Remove profile image cache * nit * fixed some tests and done some suggested changes * updates to gae_models and test file * fixed lint and mypy * edited the tests * fixed lint and backend test * lint and failing test * backend fix * admin test * initial nits * done suggested changes * lint * done suggested changes * done suggested changes * done suggested changes * nit update * nits * lint * mypy * done suggested changes * improved tests * nit * fixed backend tests * lint * added tests * req updated * done suggested changes * lint * mypy * fixed backend * removed a check * removed the unnecessary check * removed the username check * mypy * name change * changes for local file storage * formating * nit * updated get-profile function * updated getProfileImageDataUrlAsync * handled the get request of profile picture * fixed backend test * removed unneeded variable * updated frontend profile picture access * removed the promise and updated the func to return url * updated as per comments * returning tuple of profile image urls * lints * updated as per comments * done some suggested changes * nits * nit * fixed tests * nits * fixed some tests * fix user service test * updated tests and lint * fixed blof dashboard test * python type checking resolved * fixed tests * fixed python type checking * fixed the frontend tests * some suggested nits * fixed e2e test * lint * fixed backend test * fixed backend test, lints and some preferences-page errors * fixed few frontend tests * fixed backend test * fixed linting and e2e * removed previously implemented jobs * backend fix * added job name to valid.py file --------- Co-authored-by: EricZLou <ericzlou@gmail.com>

@gp201

…ading numbers (oppia#18134) * Now Chromevox can read close button for x icon after uploading a picture * label-fix-chromvox * fix-ffa * fix-read-percentage-lesson-progress * fix-read-percentage-lesson-progress * progress-bar-fix * fix-progress * fix-progress * Progress-percentage-fix * fix-progressbar-read * fix-progress-bar-reading-issue * fix-progress-bar-reading-issue * fix-progress-bar-reading-issue * fix-progress-bar-reading-issue * proessbar-read-chromevox-fix * proessbar-read-chromevox-fix * progressbar-read-fix * progressbar-read-fix * progressbar-read-fix * progressbar-read-fix * progressbar-read-fix * progressbar-read-fix * progressbar-fix * progressbar-fix * progressbar-read-fix * progressbar-read-fix * progressbar-read-fix * progressbar-read-fix * progressbar-read-fix * progressbar-read-fix * progressbar-read-fix * progressbar-read-fix * Update lesson-information-card-modal.component.spec.ts Hi @gp201, I combined the two lines you mentioned into a single line, and added a space before every test. * Update lesson-information-card-modal.component.spec.ts * Update lesson-information-card-modal.component.spec.ts * Update lesson-information-card-modal.component.spec.ts

…oppia#18231) * Fix unexpected translation count issue * Remove numeric check * Fix job error log * Add new tests * Remove incorrect get_translations_count * Fix lint issue

* Make the edit profile button visible * Probable fix of Attribute Alignment linter check Signed-off-by: OctoPie23 <coveringguy0123@gmail.com> * Align the edit icon to the top right --------- Signed-off-by: OctoPie23 <coveringguy0123@gmail.com>

* Debug context service flake * Debug context service flake * Debug context service flake * Debug context service flake * Remove fdescribe * update console statements * add fdescribe * Fix flake * Fix flake * Clean up

…odebase (oppia#18226) * replaced vmid and classroom config props * removed featured-translation-languages config property * removed list-of-default-tags config props * removed exploration-whitelisted config property * fixed lint errors * lint * fixed test * restored classroom config property * replaced variable name * lint fix * fixed tests * fixed lint, type-checking and e2e tests * fixed backend test * lint * made changes to fix the tests * fixed lints and backend test * lint fix - double quote to single * restored the spaces * added test to check the list of featured translations * corrected the naming convention * fixed the typos * updated featured-translation-languages part * fixed lints * length lint fix * done suggested changes * lint fix * fixed mypy * fixed tests and did suggested changes * fixed lint * fixed backend and e2e test * fixed lint * nit changes in backend test * fixed the backend test

…om/agallop/oppia into acceptance-tests-translation-admin

sagangwee

@agallop LGTM, thanks!

oppiabot · 2023-09-29T15:20:05Z

Unassigning @sagangwee since they have already approved the PR.

oppiabot · 2023-09-29T15:20:09Z

Hi @agallop, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

Shivkant-Chauhan · 2023-09-30T06:14:45Z

@agallop thanks for the PR, adding it into the merge queue for merging the changes into develop.

seanlip · 2023-10-06T00:59:55Z

Hi @agallop -- oddly, there's an e2e test failing in the merge queue that's related to the contributor admin dashboard. Could it be related to changes you did? https://github.com/oppia/oppia/actions/runs/6422260725/job/17440346425

I'll try adding your PR to the merge queue again but the above might be worth looking at so that we don't introduce any flakes.

Thanks!

agallop · 2023-10-06T13:00:58Z

Hi @agallop -- oddly, there's an e2e test failing in the merge queue that's related to the contributor admin dashboard. Could it be related to changes you did? https://github.com/oppia/oppia/actions/runs/6422260725/job/17440346425

I'll try adding your PR to the merge queue again but the above might be worth looking at so that we don't introduce any flakes.

Thanks!

That's a weird flake. The non-test changes in this PR are just changes to some id attributes.

That being said, it did fail a second time https://github.com/oppia/oppia/actions/runs/6431123127/job/17464739142

1) Contributor Admin Dashboard should allow user to navigate to new dashboard
Expected 1 to be 2.      
      actual expected
      
      12
      
Error: Expected 1 to be 2.
    at <Jasmine>
    at ContributorDashboardAdminPage.<anonymous> (/home/runner/work/oppia/oppia/core/tests/webdriverio_utils/ContributorDashboardAdminPage.js:230:35)
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/oppia/oppia/core/tests/webdriverio_utils/ContributorDashboardAdminPage.js:17:58)

seanlip · 2023-10-06T13:49:57Z

@agallop Could the ID attribute changes possibly affect anything in the existing webdriverio CD admin page tests?

agallop and others added 28 commits May 9, 2023 21:14

Translation admin tests creation

87b7911

Translation admin tests snapshot

ed1639e

Some lint fixes and documentation for translation admin tests

9ade68e

Remove extra file

1daa3d8

minor lint changes

b572d0e

Removed Extra Spaces in add response box (oppia#17969)

b15170d

* Removed Extra Spaces in add response box * Update rule-editor.component.html --------- Co-authored-by: SUBHASH THENUA <100484672+SubhashThenua@users.noreply.github.com>

Add CI flake Issue template (oppia#18183)

166bf47

* Add CI template * minor lint fix * Minor fixes

Fix oppia#17002: Fix exploration load before save progress modal (opp…

d6b6764

…ia#18110) * Fix exploration load before save progress modal * fix non checkpoint explorations error * event name correction

Fixed oppia#18230: Incorrect Description of the Hausa Language Title …

57f1227

…on language dropdown. (oppia#18235) fixed-18230 Incorrect Description of the Hausa Language Title on language dropdown Changes made in constant.js only Halshen has changed into harshen

Fix oppia#18055: Removes html stripping before checking empty content (…

17dd117

…oppia#18231) * Fix unexpected translation count issue * Remove numeric check * Fix job error log * Add new tests * Remove incorrect get_translations_count * Fix lint issue

Fix oppia#17956: Fixes context service frontend flake. (oppia#18152)

58eba41

* Debug context service flake * Debug context service flake * Debug context service flake * Debug context service flake * Remove fdescribe * update console statements * add fdescribe * Fix flake * Fix flake * Clean up

Successful fun of providing translation rights test

e40e865

Successful run of revoking translation rights test

0a6fcc9

Appeasing some lint rules

8b83ada

Minor lint and comment updates

281e8c5

Merge branch 'oppia:develop' into acceptance-tests-translation-admin

b491f1d

Merge branch 'acceptance-tests-translation-admin' of https://github.c…

ad01009

…om/agallop/oppia into acceptance-tests-translation-admin

Merge branch 'develop' into acceptance-tests-translation-admin

24caacc

comments update

dbc555f

agallop requested a review from a team June 6, 2023 21:07

agallop requested a review from a team as a code owner June 6, 2023 21:07

sagangwee changed the title ~~Implement part of #17712: Acceptance tests for translation admin users~~ Implement part of #17712, #18893: Acceptance tests for translation admin users Sep 29, 2023

sagangwee approved these changes Sep 29, 2023

View reviewed changes

oppiabot bot unassigned sagangwee Sep 29, 2023

oppiabot bot added the PR: LGTM label Sep 29, 2023

Shivkant-Chauhan enabled auto-merge September 30, 2023 06:14

Shivkant-Chauhan added this pull request to the merge queue Sep 30, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 30, 2023

agallop added 2 commits September 30, 2023 12:07

Merge branch 'develop' into acceptance-tests-translation-admin

2814908

Merge branch 'develop' into acceptance-tests-translation-admin

6acfc14

seanlip added this pull request to the merge queue Oct 5, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 5, 2023

seanlip added this pull request to the merge queue Oct 6, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 6, 2023

seanlip added this pull request to the merge queue Oct 6, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 6, 2023

seanlip added this pull request to the merge queue Oct 6, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 6, 2023

Merge branch 'develop' into acceptance-tests-translation-admin

701031b

seanlip enabled auto-merge October 6, 2023 13:48

seanlip added this pull request to the merge queue Oct 6, 2023

Merged via the queue into oppia:develop with commit 9d3a5d0 Oct 6, 2023
69 checks passed

agallop deleted the acceptance-tests-translation-admin branch October 6, 2023 16:42

seanlip mentioned this pull request Oct 7, 2023

[CD Acceptance Tests]: Translation Admins #18893

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement part of #17712, #18893: Acceptance tests for translation admin users #18345

Implement part of #17712, #18893: Acceptance tests for translation admin users #18345

agallop commented Jun 6, 2023 •

edited by sagangwee

sagangwee left a comment

oppiabot bot commented Sep 29, 2023

oppiabot bot commented Sep 29, 2023

Shivkant-Chauhan commented Sep 30, 2023

seanlip commented Oct 6, 2023

agallop commented Oct 6, 2023

seanlip commented Oct 6, 2023

Implement part of #17712, #18893: Acceptance tests for translation admin users #18345

Implement part of #17712, #18893: Acceptance tests for translation admin users #18345

Conversation

agallop commented Jun 6, 2023 • edited by sagangwee

Overview

Essential Checklist

Proof that changes are correct

sagangwee left a comment

Choose a reason for hiding this comment

oppiabot bot commented Sep 29, 2023

oppiabot bot commented Sep 29, 2023

Shivkant-Chauhan commented Sep 30, 2023

seanlip commented Oct 6, 2023

agallop commented Oct 6, 2023

seanlip commented Oct 6, 2023

agallop commented Jun 6, 2023 •

edited by sagangwee