Implement part of #17712 : Acceptance tests for Exploration Creator Section(CUJ 10).

.github/workflows/e2e_lighthouse_performance_acceptance_tests.yml

@@ -313,8 +313,9 @@ jobs:
             - blog-admin-tests/assign-roles-to-users-and-change-tag-properties
             - blog-editor-tests/try-to-publish-a-duplicate-blog-post-and-get-blocked
             - curriculum-admin-tests/create-and-publish-topics-and-stories
-            - exploration-editor-tests/load-complete-and-restart-exploration-preview
             - exploration-editor-tests/create-exploration-and-change-basic-settings
+            - exploration-editor-tests/load-complete-and-restart-exploration-preview
+            - exploration-editor-tests/save-draft-publish-and-discard-the-changes
             - logged-in-user-tests/click-all-buttons-on-about-page
             - logged-in-user-tests/click-all-buttons-on-about-foundation-page
             - logged-in-user-tests/click-all-buttons-on-thanks-for-donating-page

core/tests/puppeteer-acceptance-tests/puppeteer-testing-utilities/puppeteer-utils.ts

@@ -20,8 +20,10 @@ import puppeteer, {Page, Browser, Viewport, ElementHandle} from 'puppeteer';
 import testConstants from './test-constants';
 import isElementClickable from '../functions/is-element-clickable';
 import {ConsoleReporter} from './console-reporter';
+import {showMessage} from './show-message-utils';
 
 const VIEWPORT_WIDTH_BREAKPOINTS = testConstants.ViewportWidthBreakpoints;
+const baseURL = testConstants.URLs.BaseURL;
 
 const LABEL_FOR_SUBMIT_BUTTON = 'Submit and start contributing';
 /** We accept the empty message because this is what is sent on
@@ -289,6 +291,46 @@ export class BaseUser {
   getCurrentUrlWithoutParameters(): string {
     return this.page.url().split('?')[0];
   }
+
+  /**
+   * This function checks the exploration accessibility with help of explorationID.
+   */
+  async expectExplorationToBeAccessibleByUrl(
+    explorationId: string | null
+  ): Promise<void> {
+    if (!explorationId) {
+      throw new Error('ExplorationId is null');
+    }
+    const explorationUrlAfterPublished = `${baseURL}/create/${explorationId}#/gui/Introduction`;
+    try {
+      await this.page.goto(explorationUrlAfterPublished);
+      showMessage('Exploration is accessible with the URL, i.e. published.');
+    } catch (error) {
+      throw new Error('The exploration is not public.');
+    }
+  }
+
+  async expectExplorationToBeNotAccessibleByUrl(
+    explorationId: string | null
+  ): Promise<void> {
+    if (!explorationId) {
+      throw new Error('ExplorationId is null');
+    }
+    const explorationUrlAfterPublished = `${baseURL}/create/${explorationId}#/gui/Introduction`;
+    try {
+      await this.page.goto(explorationUrlAfterPublished);
+      throw new Error('The exploration is still public.');
+    } catch (error) {
+      showMessage('The exploration is not accessible with the URL.');
+    }
+  }
+
+  /**
+   * Waits for the page to fully load by checking the document's ready state.
+   */
+  async waitForPageToFullyLoad(): Promise<void> {
+    await this.page.waitForFunction('document.readyState === "complete"');
+  }
 }
 
 export const BaseUserFactory = (): BaseUser => new BaseUser();

core/tests/puppeteer-acceptance-tests/spec/curriculum-admin-tests/create-and-publish-topics-and-stories.spec.ts

@@ -42,12 +42,12 @@ describe('Curriculum Admin', function () {
       await curriculumAdmin.navigateToCreatorDashboardPage();
       await curriculumAdmin.navigateToExplorationEditorPage();
       await curriculumAdmin.dismissWelcomeModal();
-      await curriculumAdmin.createExplorationWithMinimumContent(
+      await curriculumAdmin.createMinimalExploration(
         'Test Exploration',
         'End Exploration'
       );
       await curriculumAdmin.saveExplorationDraft();
-      explorationId = await curriculumAdmin.publishExplorationWithContent(
+      explorationId = await curriculumAdmin.publishExplorationWithMetadata(
         'Test Exploration Title 1',
         'Test Exploration Goal',
         'Algebra'

core/tests/puppeteer-acceptance-tests/spec/exploration-editor-tests/create-exploration-and-change-basic-settings.spec.ts

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 /**
- * @fileoverview Acceptance Test for Exploration Creator and Exploration Manager
+ * @fileoverview Acceptance Test for settings tab in exploration editor.
  */
 
 import {ConsoleReporter} from '../../puppeteer-testing-utilities/console-reporter';
@@ -22,6 +22,7 @@ import testConstants from '../../puppeteer-testing-utilities/test-constants';
 import {UserFactory} from '../../puppeteer-testing-utilities/user-factory';
 import {CurriculumAdmin} from '../../user-utilities/curriculum-admin-utils';
 import {ExplorationEditor} from '../../user-utilities/exploration-editor-utils';
+import {LoggedInUser} from '../../user-utilities/logged-in-users-utils';
 import {VoiceoverAdmin} from '../../user-utilities/voiceover-admin-utils';
 
 const DEFAULT_SPEC_TIMEOUT_MSECS = testConstants.DEFAULT_SPEC_TIMEOUT_MSECS;
@@ -38,54 +39,62 @@ ConsoleReporter.setConsoleErrorsToIgnore([
   /Error: Could not find the resource http:\/\/localhost:8181\/explorehandler\/features\/[a-zA-Z0-9]+\.?/,
   /Could not find the resource http:\/\/localhost:8181\/createhandler\/permissions\/[a-zA-Z0-9]+\.?/,
   /http:\/\/localhost:8181\/build\/webpack_bundles\/exploration_editor\.[a-f0-9]+\.bundle\.js/,
+  /http:\/\/localhost:8181\/create\/[a-zA-Z0-9]+#\/gui\/Introduction Failed to load resource: the server responded with a status of 404 \(Not Found\)/,
 ]);
 
 describe('Exploration Creator', function () {
   let explorationEditor: ExplorationEditor;
   let voiceoverAdmin: VoiceoverAdmin;
   let curriculumAdmin: CurriculumAdmin;
+  let explorationVisitor: LoggedInUser;
   let explorationId: string | null;
 
   beforeAll(async function () {
     explorationEditor = await UserFactory.createNewUser(
       'explorationEditor',
       'exploration_editor@example.com'
     );
-    showMessage('explorationEditor is signed up successfully.');
+    showMessage('explorationEditor has signed up successfully.');
+
+    explorationVisitor = await UserFactory.createNewUser(
+      'explorationVisitor',
+      'exploration_visitor@example.com'
+    );
+    showMessage('explorationVisitor has signed up successfully.');
 
     voiceoverAdmin = await UserFactory.createNewUser(
       'voiceoverAdm',
       'voiceover_admin@example.com',
       [ROLES.VOICEOVER_ADMIN]
     );
-    showMessage('Voiceover admin is signed up successfully.');
+    showMessage('Voiceover admin has signed up successfully.');
 
     curriculumAdmin = await UserFactory.createNewUser(
       'curriculumAdm',
       'curriculum_admin@example.com',
       [ROLES.CURRICULUM_ADMIN]
     );
-    showMessage('Curriculum admin is signed up successfully.');
+    showMessage('Curriculum admin has signed up successfully.');
 
     const guestUser1 = await UserFactory.createNewUser(
       'guestUser1',
       'guest_user1@example.com'
     );
-    showMessage('guestUser1 is signed up successfully.');
+    showMessage('guestUser1 has signed up successfully.');
     await guestUser1.closeBrowser();
 
     const guestUser2 = await UserFactory.createNewUser(
       'guestUser2',
       'guest_user2@example.com'
     );
-    showMessage('guestUser2 is signed up successfully.');
+    showMessage('guestUser2 has signed up successfully.');
     await guestUser2.closeBrowser();
 
     const guestUser3 = await UserFactory.createNewUser(
       'guestUser3',
       'guest_user3@example.com'
     );
-    showMessage('guestUser3 is signed up successfully.');
+    showMessage('guestUser3 has signed up successfully.');
     await guestUser3.closeBrowser();
   }, DEFAULT_SPEC_TIMEOUT_MSECS);
 
@@ -98,7 +107,7 @@ describe('Exploration Creator', function () {
 
       await explorationEditor.dismissWelcomeModal();
 
-      await explorationEditor.createExplorationWithMinimumContent(
+      await explorationEditor.createMinimalExploration(
         'Exploration intro text',
         INTERACTION_TYPES.END_EXPLORATION
       );
@@ -155,7 +164,7 @@ describe('Exploration Creator', function () {
       await curriculumAdmin.openExplorationControlDropdown();
       await curriculumAdmin.deleteExplorationPermanently();
 
-      await explorationEditor.expectExplorationToBeNotAccessibleByUrl(
+      await explorationVisitor.expectExplorationToBeNotAccessibleByUrl(
         explorationId
       );
     },

core/tests/puppeteer-acceptance-tests/spec/exploration-editor-tests/save-draft-publish-and-discard-the-changes.spec.ts

@@ -0,0 +1,88 @@
+// Copyright 2024 The Oppia Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS-IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+/**
+ * @fileoverview Acceptance Test for saving drafts, publishing, and discarding changes.
+ */
+
+import {showMessage} from '../../puppeteer-testing-utilities/show-message-utils';
+import testConstants from '../../puppeteer-testing-utilities/test-constants';
+import {UserFactory} from '../../puppeteer-testing-utilities/user-factory';
+import {ExplorationEditor} from '../../user-utilities/exploration-editor-utils';
+import {LoggedInUser} from '../../user-utilities/logged-in-users-utils';
+
+const DEFAULT_SPEC_TIMEOUT_MSECS = testConstants.DEFAULT_SPEC_TIMEOUT_MSECS;
+enum INTERACTION_TYPES {
+  END_EXPLORATION = 'End Exploration',
+}
+
+describe('Exploration Creator', function () {
+  let explorationEditor: ExplorationEditor;
+  let explorationVisitor: LoggedInUser;
+  let explorationId: string | null;
+
+  beforeAll(async function () {
+    explorationEditor = await UserFactory.createNewUser(
+      'explorationEditor',
+      'exploration_editor@example.com'
+    );
+    showMessage('explorationEditor has signed up successfully.');
+
+    explorationVisitor = await UserFactory.createNewUser(
+      'explorationVisitor',
+      'exploration_visitor@example.com'
+    );
+    showMessage('explorationVisitor has signed up successfully.');
+  }, DEFAULT_SPEC_TIMEOUT_MSECS);
+
+  it(
+    'should draft, discard and publish the changes',
+    async function () {
+      await explorationEditor.navigateToCreatorDashboardPage();
+      await explorationEditor.navigateToExplorationEditorPage();
+      await explorationEditor.dismissWelcomeModal();
+
+      await explorationEditor.createMinimalExploration(
+        'Exploration intro text',
+        INTERACTION_TYPES.END_EXPLORATION
+      );
+
+      await explorationEditor.saveExplorationDraft();
+      explorationId = await explorationEditor.publishExplorationWithMetadata(
+        'Old Title',
+        'This is the goal of exploration.',
+        'Algebra'
+      );
+
+      await explorationVisitor.expectExplorationToBeAccessibleByUrl(
+        explorationId
+      );
+
+      await explorationEditor.navigateToSettingsTab();
+
+      await explorationEditor.updateTitleTo('New Title');
+      await explorationEditor.discardCurrentChanges();
+      await explorationEditor.expectTitleToBe('Old Title');
+
+      await explorationEditor.updateTitleTo('New Title');
+      await explorationEditor.saveExplorationDraft();
+      await explorationEditor.expectTitleToBe('New Title');
+    },
+    DEFAULT_SPEC_TIMEOUT_MSECS
+  );
+
+  afterAll(async function () {
+    await UserFactory.closeAllBrowsers();
+  });
+});

core/tests/puppeteer-acceptance-tests/spec/voiceover-admin-tests/add-voiceover-artist-to-an-exploration.spec.ts

@@ -66,12 +66,12 @@ describe('Voiceover Admin', function () {
       await explorationEditor.navigateToExplorationEditorPage();
       await explorationEditor.dismissWelcomeModal();
 
-      await explorationEditor.createExplorationWithMinimumContent(
+      await explorationEditor.createMinimalExploration(
         'Exploration one',
         INTERACTION_TYPES.END_EXPLORATION
       );
       await explorationEditor.saveExplorationDraft();
-      explorationId = await explorationEditor.publishExplorationWithContent(
+      explorationId = await explorationEditor.publishExplorationWithMetadata(
         'Exploration one',
         'Exploration one',
         'Algebra'
@@ -106,12 +106,12 @@ describe('Voiceover Admin', function () {
       await explorationEditor.navigateToCreatorDashboardPage();
       await explorationEditor.navigateToExplorationEditorPage();
 
-      await explorationEditor.createExplorationWithMinimumContent(
+      await explorationEditor.createMinimalExploration(
         'Exploration two',
         INTERACTION_TYPES.END_EXPLORATION
       );
       await explorationEditor.saveExplorationDraft();
-      explorationId = await explorationEditor.publishExplorationWithContent(
+      explorationId = await explorationEditor.publishExplorationWithMetadata(
         'Exploration one',
         'Exploration one',
         'Algebra'

core/tests/puppeteer-acceptance-tests/user-utilities/curriculum-admin-utils.ts

@@ -764,7 +764,7 @@ export class CurriculumAdmin extends BaseUser {
    * Function to navigate to exploration settings tab
    */
   async navigateToExplorationSettingsTab(): Promise<void> {
-    await this.page.waitForFunction('document.readyState === "complete"');
+    await this.waitForPageToFullyLoad();
     if (this.isViewportAtMobileWidth()) {
       await this.clickOn(mobileNavToggelbutton);
       await this.clickOn(mobileOptionsDropdown);
@@ -780,7 +780,7 @@ export class CurriculumAdmin extends BaseUser {
    * Note: This action requires Curriculum Admin role.
    */
   async deleteExplorationPermanently(): Promise<void> {
-    await this.page.waitForFunction('document.readyState === "complete"');
+    await this.waitForPageToFullyLoad();
     await this.clickOn(deleteExplorationButton);
     await this.clickOn(confirmDeletionButton);
   }