-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6062: Alignment of the sharing logos at bottom set correctly. #6145
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6145 +/- ##
========================================
Coverage 45.33% 45.33%
========================================
Files 525 525
Lines 30869 30869
Branches 4615 4615
========================================
Hits 13993 13993
Misses 16876 16876 Continue to review full report at Codecov.
|
hi @Dilshaad21 can you please write in the explanation
|
@17bcs029 I have put a short summary of the bugfix. Thanks! |
Hi @Dilshaad21, why the |
@anubhavsinha98 I have only moved the rightmost logo down it won't affect if any other logo is there in the left side of it. Even if google+ is there ,it will work on these changes. |
Hi @Dilshaad21, Thanks for the PR but we already have one ongoing PR (#6143) for this issue. I would suggest you to pick open issues and close this PR for now! (I think @anubhavsinha98 has already suggested you over here) |
@DubeySandeep I did the PR after asking @anubhavsinha98 on glitter. And the other ongoing PR #6143 was done just after I did my PR #6141 (But I had to change it because I did it from develop branch so I closed it.). |
@Dilshaad21, I can understand the problem but unfortunately, we can only have one PR for an issue at a time. It would be great if you can help us do UI review for #6143? In general, try looking up for open issues so that we should never be in this kinda scenario. |
This is my first PR I don't want to end up like that.@anubhavsinha98 @DubeySandeep |
Hi @Dilshaad21 , as I checked that @jeeb0xical commented first on the issue to work. |
Explanation
Before bugfix it was as shown below.
Checklist
python scripts/pre_commit_linter.py
andbash scripts/run_frontend_tests.sh
.