Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6062: Alignment of the sharing logos at bottom set correctly. #6145

Closed
wants to merge 1 commit into from

Conversation

Dilshaad21
Copy link

@Dilshaad21 Dilshaad21 commented Jan 21, 2019

Explanation

Before bugfix it was as shown below.
ubuntu 64-bit - vmware workstation 21-01-2019 18_29_45

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@Dilshaad21 Dilshaad21 changed the title Alignment of the sharing logos at bottom set correctly. Fix #6062: Alignment of the sharing logos at bottom set correctly. Jan 21, 2019
@codecov-io
Copy link

codecov-io commented Jan 21, 2019

Codecov Report

Merging #6145 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6145   +/-   ##
========================================
  Coverage    45.33%   45.33%           
========================================
  Files          525      525           
  Lines        30869    30869           
  Branches      4615     4615           
========================================
  Hits         13993    13993           
  Misses       16876    16876

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce50b87...7a86453. Read the comment docs.

@keshavg2
Copy link
Contributor

hi @Dilshaad21 can you please write in the explanation

  • Fixes #bugnum , followed by a short summry of the changes
    Thanks

@Dilshaad21
Copy link
Author

@17bcs029 I have put a short summary of the bugfix. Thanks!

@anubhavsinha98
Copy link
Contributor

anubhavsinha98 commented Jan 22, 2019

Hi @Dilshaad21, why the google+ logo is not available on your local setup ?

@Dilshaad21
Copy link
Author

Dilshaad21 commented Jan 22, 2019

@anubhavsinha98 I have only moved the rightmost logo down it won't affect if any other logo is there in the left side of it. Even if google+ is there ,it will work on these changes.

@DubeySandeep
Copy link
Member

DubeySandeep commented Jan 22, 2019

Hi @Dilshaad21, Thanks for the PR but we already have one ongoing PR (#6143) for this issue. I would suggest you to pick open issues and close this PR for now! (I think @anubhavsinha98 has already suggested you over here)

@Dilshaad21
Copy link
Author

Dilshaad21 commented Jan 22, 2019

@DubeySandeep I did the PR after asking @anubhavsinha98 on glitter. And the other ongoing PR #6143 was done just after I did my PR #6141 (But I had to change it because I did it from develop branch so I closed it.).
Now this is the new PR done by me.

@DubeySandeep
Copy link
Member

@Dilshaad21, I can understand the problem but unfortunately, we can only have one PR for an issue at a time. It would be great if you can help us do UI review for #6143?

In general, try looking up for open issues so that we should never be in this kinda scenario.

@Dilshaad21
Copy link
Author

Dilshaad21 commented Jan 22, 2019

This is my first PR I don't want to end up like that.@anubhavsinha98 @DubeySandeep

@anubhavsinha98
Copy link
Contributor

anubhavsinha98 commented Jan 23, 2019

Hi @Dilshaad21 , as I checked that @jeeb0xical commented first on the issue to work.
And there are many more issues which are labeled as good first issue, you can also work on them.

@Dilshaad21 Dilshaad21 closed this Jan 23, 2019
@Dilshaad21 Dilshaad21 deleted the patch_1 branch January 30, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the alignment of the logos of google+, facebook and twitter on page of any exploration.
6 participants