Fix part of #8015: editable.question.backend.api.service.ts now returns a domain object …

[robatras]

Overview

1. This PR fixes or fixes part of Backend api service in frontend should return domain object instead of dict #8015.
2. This PR does the following: editable-question-backend-api now returns a question object instead of question dict and associated skills objects instead of associated skills dicts. questions-list.directive is modified to directly use objects returned from the service.
   modified the tests spec to expect domain object.

Essential Checklist

• [ X] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• [ X] The linter/Karma presubmit checks have passed locally on your machine.
• [ X] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • This lets reviewers restart your CircleCI tests for you.
• [ X] The PR is made from a branch that's not called "develop".

PR Pointers

• Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
• For what code owners will expect, see the Code Owner's wiki page.
• Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
• Never force push. If you do, your PR will be closed.

[oppiabot]

Hi, @robatras. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

[robatras]

@seanlip @DubeySandeep PTAL! @yudani-s and I worked on this together

[vinitamurthi]

Code looks okay, have you verified it by running a local server as well?

[kevinlee12]

@robatras Please edit your PR title so that it fits what point 1 in the essential checklist is asking. Also, did you bypass the push verification checks?

[oppiabot]

Assigning @ankita240796 for the first-pass review of this pull request. Thanks!

[robatras]

@robatras Please edit your PR title so that it fits what point 1 in the essential checklist is asking. Also, did you bypass the push verification checks?

Just edited it! Currently working on fixing the frontend issue test. And, i followed the instructions for pushing it; however, somehow, it did bypass the checks. @kevinlee12

[kevinlee12]

Did you run python -m scripts.start?

[yudani-s]

Did you run python -m scripts.start?

Hi, I worked with @robatras on this task. Yes, we did run python -m scripts.start, and the development server seemed to have the same functionality from what we could tell.

[kevinlee12]

What was the result after you run the frontend tests locally? The command is python -m scripts.run_frontend_tests

[robatras]

@kevinlee12 When we run the frontend command locally, all tests pass and we receive this:
TOTAL: 2035 SUCCESS

[kevinlee12]

Can you try to merge from upstream/develop and push again?

[robatras]

@kevinlee12 Just pushed it again and looks like all tests are passing like before, but the karma coverage error at the bottom still exists.

[kevinlee12]

Ah, sorry, I missed the coverage error the first time. The prepush checks doesn't check for coverage, so in this case, you need to write more tests to ensure that there's 100% coverage. If you need assistance, let me know and I'll redirect you to the right person to assist.

[codecov]

Codecov Report

Merging #8986 into develop will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff            @@
##           develop    #8986   +/-   ##
========================================
  Coverage    53.41%   53.42%           
========================================
  Files          870      870           
  Lines        35764    35766    +2     
  Branches      4250     4250           
========================================
+ Hits         19103    19105    +2     
  Misses       15728    15728           
  Partials       933      933           

Flag	Coverage Δ
#frontend	53.42% <75.00%> (+<0.01%)	⬆️

Impacted Files	Coverage Δ
...ectives/questions-list/questions-list.directive.ts	5.78% <0.00%> (ø)
.../question/editable-question-backend-api.service.ts	84.13% <100.00%> (+0.52%)	⬆️