-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #8015 and Fix #9914: Refactor backend-api services to return domain objects. #9917
Merged
seanlip
merged 15 commits into
oppia:develop
from
nishantwrp:refactor-backend-api-services-3
Jul 20, 2020
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0b5f937
Topics and Skills Dashboard (All checks passing)
nishantwrp de976b5
Backend tests
nishantwrp 95bf9bb
All other files done (Tests passing)
nishantwrp c76eca2
Merge remote-tracking branch 'upstream/develop' into refactor-backend…
nishantwrp 2e26a86
Fix issues with merge
nishantwrp ba36493
Minor Bug
nishantwrp fa12ccc
reviews
nishantwrp 3830025
Merge remote-tracking branch 'upstream/develop' into refactor-backend…
nishantwrp 89b955e
reviews
nishantwrp 1404990
reviews
nishantwrp 196dd33
reviews
nishantwrp 50123ab
reviews
nishantwrp 65f528d
reviews
nishantwrp f63e7a1
Merge remote-tracking branch 'upstream/develop' into refactor-backend…
nishantwrp 4336517
Fix issues with merge
nishantwrp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this because of two reasons
categorized_skills_dict
is a dict with topic names as keys. In typescript if there's a dict all the values should be of same type.untriaged_skill_summary_dicts
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nishantwrp, adding @Showtim3 for review since he can advise on whether this change makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok @seanlip, Please note that to declare a type for this in the backend-api service. This is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup sorry -- I don't disagree. I think @Showtim3 and you would need to collaborate to make sure that the changes to the data structure look good and are propagated correctly. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the changes look okay. Tested them locally also.