Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unassign the author after addition of PR CHANGELOG label #212

Closed
SAEb-ai opened this issue Mar 14, 2021 · 2 comments
Closed

Unassign the author after addition of PR CHANGELOG label #212

SAEb-ai opened this issue Mar 14, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@SAEb-ai
Copy link
Contributor

SAEb-ai commented Mar 14, 2021 •
edited
Loading

Oppiabot should unassign the author after the PR CHANGELOG label is added. This is meant only for this job only. But if the reviewer has requested some changes then oppiabot should not unassign the author even if the PR CHANGELOG label is added. (oppia/oppia#12205)

@jameesjohn @vojtechjelinek PTAL. I want to work on this issue.
@vojtechjelinek
Copy link
Member

Done.

@SAEb-ai SAEb-ai mentioned this issue Mar 21, 2021
Closed
2 tasks
@seanlip seanlip added the enhancement New feature or request label Jan 5, 2023
@seanlip
Copy link
Member

seanlip commented Jan 6, 2023

If a user is updating the changelog label then it's easy for them to unassign themselves (in roughly the same place), and doing so would be easier than Oppiabot having to try and figure out whether they should be unassigned or not. So let's not do this.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Developer Workflow Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #212: Unassign author if changelog label added SAEb-ai/oppiabot
3 participants
@vojtechjelinek @seanlip @SAEb-ai