Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Modules to Github Actions #277

Open
16 tasks
jameesjohn opened this issue Jun 30, 2021 · 22 comments
Open
16 tasks

Migrate Modules to Github Actions #277

jameesjohn opened this issue Jun 30, 2021 · 22 comments
Labels
bug Something isn't working Impact: Medium Work: Low

Comments

@jameesjohn
Copy link
Contributor

jameesjohn commented Jun 30, 2021

The Oppiabot project is currently in a hybrid state comprising of both Github Actions and Probot.

This issue aims to migrate the features to GitHub actions and track the progress of doing that.
To be able to contribute to this, you need to read the migration guide which can be found here.

Sample PRs on migrating to Github Actions can be found here.

Available Modules to Migrate:

  • checkCriticalPr.js
  • checkForNewCodeowners.js
  • checkNewCron.js
  • checkPullRequestJob.js
  • checkPullRequestReview.js
  • checkPullRequestTemplate.js
  • ciChecks.js
  • periodicChecks.js
  • staleBuildChecks.js
  • apiForSheets.js
  • Wip/Branch Check
  • checkBranchPush.js
  • checkIssueAssignee.js
  • checkPullRequestLabels.js
  • checkPullRequestBranch.js
  • checkMergeConflicts.js

Done:

@jameesjohn jameesjohn added the good first issue Good for newcomers label Jun 30, 2021
@nlok5923
Copy link
Contributor

nlok5923 commented Jul 7, 2021

@jameesjohn i would like to work on checkIssueAssignee.js

@jameesjohn
Copy link
Contributor Author

Done @nlok5923. You can start working on it.

@khanjasir90
Copy link

@jameesjohn can i work on this checkPullRequestLabels.js

@vojtechjelinek
Copy link
Member

@khanjasir90 Would you still be interested in this issue?

@khanjasir90
Copy link

Yes

@vojtechjelinek
Copy link
Member

@khanjasir90 Done.

@SaurabhJamadagni
Copy link

Hi @vojtechjelinek @jameesjohn! Sorry for this very trivial question, but what are the technical requirements to be able to solve a task in this issue? This being my second issue ever I am a bit confused. I would really like to acquaint myself with the skills needed and contribute to this issue.

@vojtechjelinek
Copy link
Member

You should know JavaScript and the GitHub Actions API. I also recommend reading through the migration guide https://github.com/oppia/oppiabot/wiki/Migrating-to-Github-Actions and the sample PR #276

@SaurabhJamadagni
Copy link

I see. I will read up on it. I would like to give it a try. @vojtechjelinek can you please assign me staleBuildChecks.js?

@vojtechjelinek
Copy link
Member

@SaurabhJamadagni Done.

@SaurabhJamadagni
Copy link

Hi @vojtechjelinek, could you please assign me checkPullRequestBranch.js instead of staleBuildChecks.js? I am sorry for the inconvenience caused.

@vojtechjelinek
Copy link
Member

@SaurabhJamadagni Sure

@SaurabhJamadagni
Copy link

Hi @vojtechjelinek! I am going through the migration guide and I have completed the 'Migrating A Feature' steps mentioned in the documentation. I am having trouble understanding a few steps in the 'Migrating Tests' section of the guide. Could you please help me understand the step 'Mocking' mentioned? Do I have to make changes to the spec file? Thanks for sparing your time!

@vojtechjelinek
Copy link
Member

@SaurabhJamadagni Yep, you need to modify the specs, because now the tests will probably fail. Let me know if you need more info.

@SaurabhJamadagni
Copy link

@SaurabhJamadagni Yep, you need to modify the specs, because now the tests will probably fail. Let me know if you need more info.

@vojtechjelinek by looking at the reference PR, I understand that I will have to remove all instances of 'checkBranch' from all the spec files. Is there anything else I have to do next or is that the final step in the migration for the respective file? I am extremely sorry if these are trivial questions.

@vojtechjelinek
Copy link
Member

@SaurabhJamadagni Yep, you need to modify the specs, because now the tests will probably fail. Let me know if you need more info.

@vojtechjelinek by looking at the reference PR, I understand that I will have to remove all instances of 'checkBranch' from all the spec files. Is there anything else I have to do next or is that the final step in the migration for the respective file? I am extremely sorry if these are trivial questions.

Yeah, then you will need to check if all the tests are still passing and if not you will need to modify the so that they pass.

@vojtechjelinek
Copy link
Member

@viveky45 Done.

@coder1706
Copy link

coder1706 commented Feb 1, 2022

Hi @vojtechjelinek, I would like to work on checkMergeConflicts.js Could you assign it to me. Thanks!

@vojtechjelinek
Copy link
Member

@coder1706 Done.

@Ketan1502
Copy link

Ketan1502 commented Feb 15, 2022

hi @vojtechjelinek, can u please assign me the ciChecks.js module ?

@Ketan1502
Copy link

@vojtechjelinek can u please review the PR #300

@himanshusharma27
Copy link

I want to work on this issue . Please assign me this issue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Impact: Medium Work: Low
Projects
Status: Todo
Development

No branches or pull requests

10 participants