Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we deal with empty entries (messages and variants) #93

Closed
NilsJacobsen opened this issue Jun 10, 2024 — with Linear · 4 comments
Closed

How do we deal with empty entries (messages and variants) #93

NilsJacobsen opened this issue Jun 10, 2024 — with Linear · 4 comments

Comments

Copy link
Member

I'm not a super pro of the new slot system, but here is a short draft about what empty entries mean for different kind of situations.

@jldec @martin.lysk1
Short prep for tomorrow discussion.


-> https://www.loom.com/share/5b781f774c3545b99cbffbef244ecbbc
-> https://app.excalidraw.com/s/1RmnkzJA3Ph/74di1HkQUo2

Copy link

Thanks @nils.jacobsen will have a look!

One note in advanced: the slot system has nothing to do with empty entries for messages and variants ;-)

Copy link

jldec commented Jun 11, 2024

# topics

  1. When Messages for a locale are not present in the data they always trigger missing-translation lint rule. After editing and saving a translation, can you delete it entirely. Why is this not the same as detecting an empty string? Empty can mean fallback. It would be nice not to re-trigger the lint just for that Message (issue exists)
  2. When is a Message saved? Ideally there is no explicit save action.
  3. Regarding variants, declarations, and matchers: How do users avoid saving messaages with missing elements and other inconsistencies. This is an important topic for the editor component

Copy link
Member Author

The outcome from the meeting on Tuesday:

  • Every state should be displayable in the ui (bad state can be hacked or a result from merging)
  • Merge conflicts can be shown in an other ui component (gitfloat, right or left)
  • When the message is completely broken by a conflict show error state
  • Empty variants, messages get linted

Copy link
Member

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants