Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Treat all 2xx response code as valid when using the webhook receiver #57

Closed
floriannadaud opened this issue Jun 19, 2020 · 2 comments
Closed

Comments

@floriannadaud
Copy link

Description

I'm sending events to loki with a webhook configuration.
Events are pushed and accepted with a 204 response code from loki

However, because the status code is not 200, logs are showing this error:

2020-06-19T13:27:31Z DBG app/pkg/exporter/channel_registry.go:59 > Cannot send event error="not 200: " event="Started container xxxxxxxxxxxxxxxxx" sink=loki

kubernetes-event-exporter only consider http.StatusOK as a correct response code from this bit of code

Proposed solution

Treat all 2xx response code as valid

@mustafaakin
Copy link
Contributor

Yes, just merged a code to treat 201 as well, but it might be better just to allow all 2xx

@ffahri ffahri closed this as completed in d262b1f Jun 22, 2020
@bygui86
Copy link

bygui86 commented Dec 19, 2020

@floriannadaud can you share the configuration you used to send events to loki?

thanks a lot in advance for your help!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants