Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report pagination fails when limit is undefiined #48

Closed
1 of 4 tasks
issacg opened this issue May 18, 2019 · 2 comments
Closed
1 of 4 tasks

report pagination fails when limit is undefiined #48

issacg opened this issue May 18, 2019 · 2 comments

Comments

@issacg
Copy link

issacg commented May 18, 2019

I'm submitting a ...

  • bug report
  • feature request
  • question about the decisions made in the repository
  • question about how to use this project

Summary

When not defining a limit in report, limit will get set implicitly to 0 and pagination will always hit

results = results.slice(0, limit)

Other information

@avermeil
Copy link
Member

Indeed -- that's a pretty big oversight on our part. This bug means that the results array gets clipped when:

  • Your results array is longer than the page_size
  • You set no limit.

#49 should fix this. We'll merge it in and release a new version soon.

@avermeil
Copy link
Member

#49 has been merged, so this should be fixed. Thanks for letting us know @issacg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants