Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow minor versions of tokio to be compatible. #884

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

jshearer
Copy link
Contributor

See: rust-lang/cargo#6584 (comment)

Why

The ~ requirement is indeed more strict than ^, but Cargo strongly discourages usage of any version requirement other than ^ unless you're really sure you know what you're doing

What

Change the dependency qualifier to ~, to allow dependents using other 1.x.x tokio versions to build.

…argo#6584 (comment)

> The `~` requirement is indeed more strict than `^`, but Cargo strongly discourages usage of any version requirement other than `^` unless you're really sure you know what you're doing
@jshearer jshearer requested a review from raybejjani June 15, 2021 15:22
@jshearer jshearer requested a review from devdoshi as a code owner June 15, 2021 15:22
@github-actions github-actions bot added the fix label Jun 15, 2021
@jshearer
Copy link
Contributor Author

I'm just gonna merge this, want to get things building so I can merge https://github.com/opticdev/monorail/pull/307

@jshearer jshearer merged commit 067763c into develop Jun 15, 2021
@jshearer jshearer deleted the fix/tokio_version_permissive branch June 15, 2021 15:37
notnmeyer pushed a commit that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants