feat: Added React Native Client Engines to be sent in events #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorona
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added Two new client engine values to be sent in events.
react-native-sdk: Client name will be set to
react-native-sdkwhen a react native application will use react sdk i.e@optimizely/react-sdk.react-native-js-sdk: Client name will be set to
react-native-js-sdkwhen a react native application will use javascript sdk directly i.e@optimizely/optimizely-sdk.Client Versions
Client versions behave the way they did without any change. Current behaviour is.
react-native-js-sdkgoes withclientVersionof javascript SDK.react-native-sdkgoes withclientVersionof react SDK.Test plan
Made appropriate changes to already existing unit tests.