feat: Add ODP Datafile Parsing and Audience Evaluation #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Jun 7, 2022
Comment on lines
69
to
70
| userAttributes: UserAttributes = {}, | ||
| segments: string[] = [], |
There was a problem hiding this comment.
Is this (unpacking and passing separate) better than passing down UserContext all the way? I see that we may need to use other fields (existing one like userId, or new ones to be added later) in evaluation later.
| @@ -64,7 +66,8 @@ export class AudienceEvaluator { | |||
| evaluate( | |||
| audienceConditions: Array<string | string[]>, | |||
| audiencesById: { [id: string]: Audience }, | |||
| userAttributes: UserAttributes = {} | |||
| userAttributes: UserAttributes = {}, | |||
| segments: string[] = [], | |||
There was a problem hiding this comment.
add 'segments' in doc comments
| @@ -99,14 +102,14 @@ export class AudienceEvaluator { | |||
| * @param {Condition} condition A single condition object to evaluate. | |||
| * @return {boolean|null} true if the condition is satisfied, null if a matcher is not found. | |||
| */ | |||
| evaluateConditionWithUserAttributes(userAttributes: UserAttributes, condition: Condition): boolean | null { | |||
| evaluateConditionWithUserAttributes(userAttributes: UserAttributes, segments: string[], condition: Condition): boolean | null { | |||
jaeopt
requested changes
Jun 22, 2022
| @@ -29,6 +29,7 @@ export default class OptimizelyUserContext { | |||
| private userId: string; | |||
| private attributes: UserAttributes; | |||
| private forcedDecisionsMap: { [key: string]: { [key: string]: OptimizelyForcedDecision } }; | |||
| private qualifiedSegments: string[] = []; | |||
There was a problem hiding this comment.
Can we open {get, set} for this prop to public? They can override it with own segments for debugging or other purposes?
| } | ||
|
|
||
| function qualifiedEvaluator(condition: Condition, user: OptimizelyUserContext): boolean { | ||
| //return user.getQualifiedSegments().indexOf(condition.value as string) > -1; |
| } | ||
| const audience = new AudienceEvaluator(); | ||
|
|
||
| it('shoud evaluate to true if segment is found', () => { |
There was a problem hiding this comment.
Suggested change
| it('shoud evaluate to true if segment is found', () => { | |
| it('should evaluate to true if segment is found', () => { |
fix same for others below
opti-jnguyen
changed the title
|
@zashraf1985 - I believe I fixed the import issues, however although the Git Actions shows all tests passing there seems to be 2 failing / 2 pending checks still. What am I missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A new field
integrationsand new audience typeodp.audienceswill be added to the datafile schema for ODP integration.Parses new datafile odp values (“publicKey” and “host”) from the “integrations” section. These values are used to send requests to the ODP server.
Parses datafile with and without the “integrations” section or empty section as well.
support a new audience with the
odp.audiencesandqualifiedmatch.support any (allowed) combination of audiences, including ODP and other existing audiences.
Test plan
Issues