Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOY_L and JOY_R are swapped in CPU_Def.i #17

Closed
clbr opened this issue Sep 6, 2018 · 1 comment
Closed

JOY_L and JOY_R are swapped in CPU_Def.i #17

clbr opened this issue Sep 6, 2018 · 1 comment

Comments

@clbr
Copy link

clbr commented Sep 6, 2018

The shoulder button defines are the wrong way around. Curious that it's not been noticed til now, maybe so few games use them.

Master:

JOY_L                   = $0010
JOY_R                   = $0020

nocash docs:

15          1st        Button B          (1=Low=Pressed)
  14          2nd        Button Y
  13          3rd        Select Button
  12          4th        Start Button
  11          5th        DPAD Up
  10          6th        DPAD Down
  9           7th        DPAD Left
  8           8th        DPAD Right
  7           9th        Button A
  6           10th       Button X
  5           11th       Button L
  4           12th       Button R
  3           13th       0 (High)
  2           14th       0 (High)
  1           15th       0 (High)
  0           16th       0 (High)
@Optiroc
Copy link
Owner

Optiroc commented Sep 7, 2018

Good catch! Admittedly I've never done anything that makes use of the shoulder buttons, so this is an error that's been around for a long time. Fixed.

@Optiroc Optiroc closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants