Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove description about optuna study optimize from examples and docs. #1394

Closed
22 of 25 tasks
toshihikoyanase opened this issue Jun 19, 2020 · 9 comments · Fixed by #3902
Closed
22 of 25 tasks

Remove description about optuna study optimize from examples and docs. #1394

toshihikoyanase opened this issue Jun 19, 2020 · 9 comments · Fixed by #3902
Assignees
Labels
document Documentation related. no-stale Exempt from stale bot

Comments

@toshihikoyanase
Copy link
Member

toshihikoyanase commented Jun 19, 2020

Motivation

#1384 deprecated the optuna study optimize command, but many examples have descriptions about it at the top of the files. I think we can remove them for consistency.

Description

Please remove the descriptions about optuna study optimize from example files.

  • docs/source/faq.rst (this section)
  • docs/source/tutorial/cli.rst
  • docs/source/tutorial/configurations.rst
  • examples/allennlp/allennlp_jsonnet.py
  • examples/allennlp/allennlp_simple.py
  • examples/catalyst_simple.py
  • examples/catboost_simple.py
  • examples/chainer_simple.py
  • examples/dask_ml_simple.py
  • examples/keras_simple.py
  • examples/lightgbm_simple.py
  • examples/lightgbm_tuner_cv.py
  • examples/lightgbm_tuner_simple.py
  • examples/mxnet_simple.py
  • examples/optuna_search_cv_simple.py
  • examples/pytorch_ignite_simple.py
  • examples/pytorch_lightning_simple.py
  • examples/pytorch_simple.py
  • examples/quadratic_simple.py
  • examples/skimage_lbp_simple.py
  • examples/sklearn_additional_args.py
  • examples/sklearn_simple.py
  • examples/tensorflow_eager_simple.py
  • examples/tensorflow_estimator_simple.py
  • examples/xgboost_simple.py

Example

This is just an example of the fix. Please feel free to change it depending on the examples.

Before:

We have the following two ways to execute this example:

(1) Execute this code directly.
    $ python quadratic_simple.py


(2) Execute through CLI.
    $ STUDY_NAME=`optuna create-study --storage sqlite:///example.db`
    $ optuna study optimize quadratic_simple.py objective --n-trials=100 --study-name $STUDY_NAME \
      --storage sqlite:///example.db

After:

You can run this example as follows:
    $ python quadratic_simple.py
@toshihikoyanase toshihikoyanase added example contribution-welcome Issue that welcomes contribution. good first issue Good first issue for contribution. labels Jun 19, 2020
@ritvik1512
Copy link
Contributor

I would like to try to tackle this. Thanks!

@ritvik1512
Copy link
Contributor

ritvik1512 commented Jun 29, 2020

I would like to confirm, as the command optuna study optimize itself is deprecated, should I also remove entire section related to optimzation through study optimize?

For example, docs/source/tutorial/cli.rst has a section on optimization at the very end, does that needs to be removed completely? Thank you

@github-actions
Copy link
Contributor

This issue has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Jul 13, 2020
@himkt
Copy link
Member

himkt commented Jul 22, 2020

@ritvik1512

Thank you for your interest on the issue and really sorry for the late reply.
We'd like to work on this issue by the following steps:

  1. Remove instructions for optuna study optimize in examples ← [now]
  2. Remove the documentation for optuna study optimize
  3. Update tutorial. In our documentation, it doesn't describe the usage of several commands in Optuna CLI commands: storage update, studies, create study, and dashboard. We need to create tutorials for them. Let me create another issue for this task.

So, for this issue, we can concentrate on removing descriptions for optuna study optimize from examples. Please focus on step #1 if you are still interested in this issue.

Thanks,

@ritvik1512
Copy link
Contributor

Thank you for taking the time to list out the steps, I'll start with #1 for now.

@ritvik1512
Copy link
Contributor

I have added PR #1566 that should address the removal of optuna study optimize from examples.

@toshihikoyanase
Copy link
Member Author

#1566 removed the optuna study optimize from the examples. Thanks, @ritvik1512 !

The documents still contain the description of optuna study optimize. Please refer to this comment to find the details of the remaining tasks.

  • docs/source/faq.rst (this section)
  • docs/source/tutorial/cli.rst
  • docs/source/tutorial/configurations.rst

@toshihikoyanase toshihikoyanase added document Documentation related. and removed example labels Aug 4, 2020
@toshihikoyanase toshihikoyanase added the no-stale Exempt from stale bot label Aug 13, 2020
@toshihikoyanase toshihikoyanase removed contribution-welcome Issue that welcomes contribution. good first issue Good first issue for contribution. labels Aug 22, 2020
@hvy hvy added no-stale Exempt from stale bot and removed no-stale Exempt from stale bot labels May 6, 2021
@Crissman Crissman self-assigned this Jun 30, 2021
@nzw0301
Copy link
Member

nzw0301 commented Mar 9, 2022

I briefly re-organise #1394 (comment) to close this issue.

tutorial/20_recipes/004_cli.py's main content, this page, is about this deprecated example, so I'm not sure how to change this tutorial...

@himkt
Copy link
Member

himkt commented Mar 14, 2022

[memo] In #3032, CLI tutorial is planned to be updated removing deprecated functionalities.

@nzw0301 nzw0301 linked a pull request Sep 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related. no-stale Exempt from stale bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants