Removing references to deprecated optuna study optimize commands from examples
#1566
Conversation
There was a problem hiding this comment.
Thanks a lot for tackling the issue. I left a comment that applies to more or less all of the examples. Could you take a look?
Also, are you able to merge/rebase the latest master and apply the same change to the recently introduced Catalyst example?
|
By the way, you can navigate to CircleCI's CI results from the list of jobs at the bottom. You can debug failure such as the one caused by the Catalyst examples in https://app.circleci.com/pipelines/github/optuna/optuna/1811/workflows/0fd24f83-ce8f-47be-9fc0-1a0280f4f741/jobs/50690. 🙂 |
|
Not quite sure why the dependency installation failed in the doctest |
|
Seems like a 502 error from pip. It happens sometimes when the server is under heavy load and is likely gone if retried (e.g. by another commit being pushed here or having the build re-run from the CircleCI dashboard). In any case, I don't think it's related to your changes. |
|
Seems like you got some unrelated commits in this PR now. Could you resolved it? If you're struggling, I could create a new PR with your commits something along https://github.com/optuna/optuna/compare/master...hvy:1566-fix?expand=1 |
There was a problem hiding this comment.
Changes LGTM!
For the record, we ended up continuing on this PR as discussed in #1580 (comment).
|
@ritvik1512 again, thanks for addressing #1394. It might be less interesting to work on similar issues but if you'd for instance like to continue working on the remaining files under |
|
Thanks, I'll stick around to help as much as I can! |
Motivation
Directly addresses issue #1394
This is the first step towards removing references to the deprecated
optuna study optimizecommand from the attached examples.Description of the changes
Removed mentions about
optuna study optimizefrom the attached examples.