Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Depends on #2025] Remove plotly scripts and unused generated files #2026

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

hvy
Copy link
Member

@hvy hvy commented Nov 16, 2020

Motivation

Follow up to #1944 removing unused files and scripts.

Depends on #2025. (edit: merged)

Description of the changes

Remove unused files and old scripts.

@hvy hvy added the document Documentation related. label Nov 16, 2020
@codecov-io
Copy link

codecov-io commented Nov 16, 2020

Codecov Report

Merging #2026 (76bcd78) into master (fe4aa34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2026   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         124      124           
  Lines        9559     9559           
=======================================
  Hits         8820     8820           
  Misses        739      739           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4aa34...76bcd78. Read the comment docs.

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HideakiImamura HideakiImamura self-assigned this Nov 16, 2020
Copy link
Contributor

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HideakiImamura HideakiImamura merged commit 3455f17 into optuna:master Nov 16, 2020
@HideakiImamura HideakiImamura added this to the v2.4.0 milestone Nov 16, 2020
@hvy hvy deleted the rm-plotly-scripts branch November 16, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants