New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install OpenBLAS for mxnet1.8.0 #2508
Conversation
Thanks for the quick PR. In case it works, I'd suggest we leave comments. |
Could you also update the coverage.yml ? |
Co-authored-by: Hiroyuki Vincent Yamazaki <hiroyuki.vincent.yamazaki@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples
include MXnet examples, but .github/workflows/examples.yml
is not updated. Is it intentional?
Codecov Report
@@ Coverage Diff @@
## master #2508 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 135 135
Lines 11308 11308
=======================================
Hits 10153 10153
Misses 1155 1155 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your swift actions! LGTM!
Install OpenBLAS for mxnet1.8.0 to successfully dlopen libopenblas.so.0.