Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install OpenBLAS for mxnet1.8.0 #2508

Merged
merged 3 commits into from Mar 22, 2021
Merged

Conversation

crcrpar
Copy link
Contributor

@crcrpar crcrpar commented Mar 22, 2021

Install OpenBLAS for mxnet1.8.0 to successfully dlopen libopenblas.so.0.

@crcrpar crcrpar added the CI Continuous integration. label Mar 22, 2021
@hvy
Copy link
Member

hvy commented Mar 22, 2021

Thanks for the quick PR. In case it works, I'd suggest we leave comments.
By the way, https://pypi.org/project/mxnet/ states that libquadmath0 is required. Is this a different topic? (Edit: seems that way)

@hvy
Copy link
Member

hvy commented Mar 22, 2021

Could you also update the coverage.yml ?

@crcrpar crcrpar marked this pull request as ready for review March 22, 2021 01:43
@crcrpar crcrpar requested a review from hvy March 22, 2021 01:47
.github/workflows/examples.yml Outdated Show resolved Hide resolved
Co-authored-by: Hiroyuki Vincent Yamazaki <hiroyuki.vincent.yamazaki@gmail.com>
Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HideakiImamura HideakiImamura self-assigned this Mar 22, 2021
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples include MXnet examples, but .github/workflows/examples.yml is not updated. Is it intentional?

Dockerfile Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #2508 (648f62e) into master (9f89399) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2508   +/-   ##
=======================================
  Coverage   89.78%   89.78%           
=======================================
  Files         135      135           
  Lines       11308    11308           
=======================================
  Hits        10153    10153           
  Misses       1155     1155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f89399...648f62e. Read the comment docs.

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your swift actions! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants