Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _get_distribution from visualization/matplotlib/_param_importances.py #2604

Merged
merged 1 commit into from Apr 20, 2021
Merged

Remove _get_distribution from visualization/matplotlib/_param_importances.py #2604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions optuna/visualization/matplotlib/_param_importances.py
View file
Open in desktop
Expand Up @@ -7,7 +7,6 @@

import optuna
from optuna._experimental import experimental
from optuna.distributions import BaseDistribution
from optuna.importance._base import BaseImportanceEvaluator
from optuna.logging import get_logger
from optuna.study import Study
Expand Down Expand Up @@ -141,10 +140,3 @@ def _get_param_importance_plot(
)

return ax


def _get_distribution(param_name: str, study: Study) -> "BaseDistribution":
for trial in study.trials:
if param_name in trial.distributions:
return trial.distributions[param_name]
assert False