Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer: make PHP version future-proof #14

Merged
merged 1 commit into from
Jun 30, 2016
Merged

composer: make PHP version future-proof #14

merged 1 commit into from
Jun 30, 2016

Conversation

TomasVotruba
Copy link

No description provided.

@meinemitternacht
Copy link

meinemitternacht commented Jun 29, 2016

Pretty sure this won't pass with PHP 7.1

@davidbyoung
Copy link
Member

@meinemitternacht If I understand Composer version constraints correctly, ^7.0 means >=7.0.0,<8.0.0. I'm not sure @TomasVotruba's change will prevent Opulence from working with PHP 7.1. Or, have I missed something?

@meinemitternacht
Copy link

Disregard, I should not have assumed similarity between their syntax and Regex.

@TomasVotruba
Copy link
Author

@opulencephp That is exactly right. ^7.0 allow all 7.x versions, but not above.
Thus, 7.1 will work.

@f3l1x
Copy link

f3l1x commented Jun 29, 2016

@TomasVotruba

~7.0 and ^7.0 are equals right?


By official documentation.

~1.2 is equivalent to >=1.2 <2.0.0
^1.2.3 is equivalent to >=1.2.3 <2.0.0

Am I right?


PS: I have always thought that caret (^) has the main purpose for for 3 digits, I mean patch version.
Like for example ^7.0.8. It means I want to obtain higher then 7.0.8 and lower then 8.0.0.

Thanks for explanation.

@davidbyoung
Copy link
Member

@TomasVotruba
Copy link
Author

@f3l1x For php version check they are the same.

@davidbyoung davidbyoung merged commit abd94ec into opulencephp:1.0 Jun 30, 2016
@TomasVotruba
Copy link
Author

TomasVotruba commented Jun 30, 2016

Thank you @opulencephp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants