Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAMING] - Controller/_exercise() #171

Closed
aleone opened this issue Sep 13, 2020 · 3 comments · Fixed by #211
Closed

[NAMING] - Controller/_exercise() #171

aleone opened this issue Sep 13, 2020 · 3 comments · Fixed by #211
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@aleone
Copy link
Contributor

aleone commented Sep 13, 2020

All of our european options are autoexercised. Should we rename this action as it might be confusing? No one needs to actually exercise anything. They just have to withdraw proceeds.

Some ideas:
WithdrawLongProceeds
WithdrawProceeds
WithdrawOtokenProceeds
RedeemLongProceeds
RedeemLong
Redeem
RedeemOtoken
WithdrawTheMoneys

@antoncoding
Copy link
Contributor

I think WithdrawOtokenProceeds or RedeemOtoken sounds good.
WithdrawLongProceeds may implied clearing a vault with long otoken? because we have been using the word Long for long token in vault throughout the code base

@aparnakr
Copy link
Contributor

WithdrawOtokenProceeds sounds good to me!

@antoncoding antoncoding added this to the contract alpha milestone Sep 18, 2020
@antoncoding antoncoding added the enhancement New feature or request label Sep 18, 2020
@haythemsellami
Copy link
Member

No strong opinion here, would only prefer the shortest function name.

@antoncoding antoncoding linked a pull request Sep 27, 2020 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants