Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InputList control to select values from a dictionary of string #3169

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Add InputList control to select values from a dictionary of string #3169

merged 3 commits into from
Aug 23, 2023

Conversation

leigh-pointer
Copy link
Contributor

The control accepts a dictionary of string that can be searched using an input control.
Pages Add and Edit have implemented the control to render the list of Icons found in the Oqtane Shared namespace.

The control accepts a dictionary of string that can be searched using an input control.
Pages Add and Edit have implemented the control to render the list of Icons found in the Oqtane Shared namespace.
@leigh-pointer
Copy link
Contributor Author

@sbwalker This PR does not currently support Localization as it would be the Dictionary that needs to be localized. The Icons class the Constant name is used as the Key and the string value the Value. Keys should not be localised.

Added an icon preview to the icon selecting control
Moved Icon to the end of control
@sbwalker
Copy link
Member

@leigh-pointer I am going to merge this PR. However I am going to rework the IconList Dictionary. I realize that you were trying to take a DRY approach by using reflection on the existing constants, but I would prefer to avoid this type of logic in the Oqtane client as it adds extra complexity and processing... plus not all reflection methods are supported in hosting models such as WebAssembly or Hybrid.

@leigh-pointer
Copy link
Contributor Author

@sbwalker ok, thats cool.

@sbwalker sbwalker merged commit 34ae731 into oqtane:dev Aug 23, 2023
1 check passed
@sbwalker
Copy link
Member

@leigh-pointer I retained your reflection logic but moved the workload from the client to the server (#3178)

@leigh-pointer leigh-pointer deleted the InputList branch October 12, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants