v1.0.1b1 - Bugfix: https://github.com/oracle/dbt-oracle/issues/4 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aosingh
commented
May 13, 2022
aosingh
commented
- database param is optional. You can drop it from profiles.yml
- Introduced a new macro get_database_name() which can be used if database param is missing
- Overrides adapter methods - list_relations_without_caching(), get_relation()
- Override catalog specific method - _get_one_catalog()
- Modified snapshot macros to invoke get_database_name() if database param is missing
1. database param is optional. You can drop it from profiles.yml 2. Introduced a new macro get_database_name() which can be used if database param is missing 3. Overrides adapter methods - list_relations_without_caching(), get_relation() 4. Override catalog specific method - _get_one_catalog() 5. Modified snapshot macros to invoke get_database_name() if database param is missing
1. Removed unnecessary imports from oracle/impl.py 2. Removed UPPER() from get_database_name() macro. This is not needed
1. Updated sample_profiles.yml and profile_template.yml to remove database
|
Fixes #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.