-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Renaming the old_relation does not work in Oracle 12c+ when using DBT table materialization with missing database name in profiles.yml #4
Labels
bug
Something isn't working
Comments
ThoSap
changed the title
[Bug] Dropping the old_relation does not work in Oracle 12c+ when using DBT table materialization
[Bug] Renaming the old_relation does not work in Oracle 12c+ when using DBT table materialization
May 4, 2022
I can confirm to have the same problem |
ThoSap
changed the title
[Bug] Renaming the old_relation does not work in Oracle 12c+ when using DBT table materialization
[Bug] Renaming the old_relation does not work in Oracle 12c+ when using DBT table materialization with missing database name in profiles.yml
May 5, 2022
@geoHeil what is your take on this #3 (comment)? |
aosingh
added a commit
that referenced
this issue
May 13, 2022
1. database param is optional. You can drop it from profiles.yml 2. Introduced a new macro get_database_name() which can be used if database param is missing 3. Overrides adapter methods - list_relations_without_caching(), get_relation() 4. Override catalog specific method - _get_one_catalog() 5. Modified snapshot macros to invoke get_database_name() if database param is missing
aosingh
added a commit
that referenced
this issue
May 13, 2022
1. Removed unnecessary imports from oracle/impl.py 2. Removed UPPER() from get_database_name() macro. This is not needed
aosingh
added a commit
that referenced
this issue
May 13, 2022
1. Updated sample_profiles.yml and profile_template.yml to remove database
Merged
This issue is fixed in release dbt-oracle==1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Current Behavior
Expected Behavior
Steps To Reproduce
Run the DBT table materialization twice.
Relevant log output using
--debug
flag enabledNo response
Environment
What Oracle database version are you using dbt with?
Tested using
and
Additional Context
Pull request fix #3
The text was updated successfully, but these errors were encountered: