Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for cl.exe check for non-english languages. #3335

Merged
merged 3 commits into from
Apr 17, 2021

Conversation

FilipJirsak
Copy link
Contributor

cl.exe prints its banner in system default language. In some languages, there is word "Microsoft" before "C/C++", in other languages there is "C/C++" before "Microsoft".

Fixes #3161.

cl.exe prints its banner in system default language. In some languages, there is word "Microsoft" before "C/C++", in other languages there is "C/C++" before "Microsoft".
@graalvmbot
Copy link
Collaborator

Hello Filip Jirsák, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address filip -(at)- jirsak -(dot)- org. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@FilipJirsak
Copy link
Contributor Author

I've signed Oracle Contributor Agreement yesterday.

@olpaw olpaw self-assigned this Apr 14, 2021
@graalvmbot
Copy link
Collaborator

Filip Jirsák has signed the Oracle Contributor Agreement (based on email address filip -(at)- jirsak -(dot)- org) so can contribute to this repository.

@olpaw
Copy link
Member

olpaw commented Apr 15, 2021

@FilipJirsak your PR is in the merge queue. It will take a few days before it lands on master (the merge queue is rather long atm).

graalvmbot pushed a commit that referenced this pull request Apr 17, 2021
@graalvmbot graalvmbot merged commit e06cb5c into oracle:master Apr 17, 2021
@shibingli
Copy link

shibingli commented May 4, 2022

Chinese environment, there are some problems.

用于 x64 的 Microsoft (R) C/C++ 优化编译器 19.31.31107 版
版权所有(C) Microsoft Corporation。保留所有权利。

用法: cl [ 选项... ] 文件名... [ /link 链接选项... ]

execute command chcp 437

Microsoft (R) C/C++ Optimizing Compiler Version 19.31.31107 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

usage: cl [ option... ] filename... [ /link linkoption... ]

When verifying cl, can you execute chcp 437 first and switch the language?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

native-image toolchain check (cl.exe) on Windows doesn't work on some locales
4 participants