-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP Reactive Messaging impl #1287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
danielkec
force-pushed
the
mp-messaging
branch
4 times, most recently
from
January 16, 2020 22:24
840cbc5
to
77d8e98
Compare
danielkec
force-pushed
the
mp-messaging
branch
from
January 21, 2020 11:32
676007e
to
1046968
Compare
danielkec
force-pushed
the
mp-messaging
branch
from
February 25, 2020 11:06
1046968
to
3a4c103
Compare
paulparkinson
previously approved these changes
Feb 25, 2020
danielkec
commented
Feb 27, 2020
...profile/messaging/src/main/java/io/helidon/microprofile/messaging/MessagingCdiExtension.java
Show resolved
Hide resolved
danielkec
commented
Feb 27, 2020
microprofile/messaging/src/test/java/io/helidon/microprofile/messaging/AbstractCDITest.java
Show resolved
Hide resolved
tomas-langer
requested changes
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use flat package structure - no packages except for the main and possibly spi
.
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
… changes Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
danielkec
force-pushed
the
mp-messaging
branch
2 times, most recently
from
March 3, 2020 21:21
a72990b
to
aa2e74e
Compare
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
…order of callbacks. Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
tomas-langer
requested changes
Mar 5, 2020
...ofile/messaging/src/main/java/io/helidon/microprofile/messaging/AbstractMessagingMethod.java
Outdated
Show resolved
Hide resolved
...aging/src/main/java/io/helidon/microprofile/messaging/CompletableQueueOverflowException.java
Outdated
Show resolved
Hide resolved
* Hide unnecessary public methods Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
danielkec
commented
Mar 5, 2020
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
* Fix INCOMING_SUBSCRIBER_MSG_2_VOID signature handling Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
danielkec
commented
Mar 5, 2020
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
tomas-langer
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
enhancement
New feature or request
reactive
Reactive streams and related components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the implementation of /issues/1206
Depends on #1282