Mp messaging example #1479
Mp messaging example #1479
Conversation
danielkec
force-pushed
the
mp-messaging-example
branch
from
70ffb3f
to
1e5ae59
Compare
There was a problem hiding this comment.
- I'd like to avoid having these pictures in this repository.
- It's meant to be fancy but it's actually not, it's probably a better idea to go for a simpler look
- Check-in the javascript files in the example rather than referencing a gist
You could simplify the look by using just a blue background and hardcode the Helidon logo as SVG in the html directly.
|
@romain-grecourt Fancy is what I have been aiming for, is 140 kB really too much? |
|
It's trying to be fancy, but it's not. It's an example, keep it simple rather than lame, go to the point. |
|
I personally like the design with all these animations. It makes it nice and dynamic. I don't see anything wrong with checking it in into repository. I agree it's better to put js files in the repository. @romain-grecourt Are there any other concerns except that you don't like the design? |
|
It's hard enough to maintain a website and keep things consistent. Let's not copy stuff from the website all over the place. I don't agree with examples being fancy, they should be simple and illustrate a point. Demos can be fancy, is this a demo ? At the very least get rid of the website background, it's not meant to be reused. |
|
I think that one of the purposes of having the graphics is that we can use it in Helidon related assets such as are presentations, demos and samples. I don't agree that it must be kept on the web site only. Why the website background cannot be reused? |
|
The re-usable assets are here: https://github.com/oracle/helidon-site/tree/master/graphics. The website background was specifically designed for the parallax effect, it's not meant to be re-used ; I'm guessing that background.png was built using the individual layers of the parallax. |
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
* Remove background image * Code snippet generated locally Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
danielkec
force-pushed
the
mp-messaging-example
branch
from
1e5ae59
to
dba6ba9
Compare
|
Sorry for rebase, background image is removed and snippet is generated locally |
...oprofile/messaging-sse/src/main/java/io/helidon/microprofile/example/messaging/sse/Main.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
No description provided.