-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CORS config key from path-prefix to path-expr; method names also #1807
Conversation
…ed as an expresion or pattern, not a prefix Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A note for consistency - in Security, we have the following configuration: security.web-server:
paths:
- path: "/noRoles"
methods: ["get"]
- path: "/user[/{*}]"
methods: ["get"]
roles-allowed: ["user"] I use just This is adding a third option. Options:
I have approved this PR, as we may delay that decision for a future Helidon version... |
After a quick slack chat with Tomas, I am re-changing the config key name to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this!
Resolves #1767
The value is, in fact, used as a pattern (expression) and not a prefix.
Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com