Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor gRPC fixes #1950

Merged
merged 4 commits into from
Jun 10, 2020
Merged

Minor gRPC fixes #1950

merged 4 commits into from
Jun 10, 2020

Conversation

aseovic
Copy link
Collaborator

@aseovic aseovic commented Jun 9, 2020

Minor gRPC metrics cleanup and fix for Channel injection

tjquinno
tjquinno previously approved these changes Jun 9, 2020
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to MetricsSupport look good to me.

Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno merged commit 9837a4f into helidon-io:helidon-1.x Jun 10, 2020
@aseovic aseovic deleted the grpc-1.x-fixes branch June 10, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants