Correct the handling of additionalProperties in OpenAPI (2.x) #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3624 for 2.x
The earlier handling for
additionalPropertiesin OpenAPI was flawed. TheadditionalPropertiessetting in an OpenAPI document can be either boolean or a schema.The MP OpenAPI
Schemaclass exposes additional properties as getters and setters foradditionalProperties(now deprecated),additionalPropertiesBoolean, andadditionalPropertiesSchema.This situation presents some challenges for serializing and deserializing OpenAPI documents and the earlier code did not do this correctly through its customizations to the SnakeYAML parsing and rendering.
This PR fixes those problems and adds more tests for both input and output.