Fix gRPC examples that are failing. #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
klustria
commented
Jul 21, 2022
•
klustria
commented
- Use built-in JsobBMarshaller for the gRPC request/response that needs it by setting it as the custom marshaller.
- Update pom.xml for microservices example because the contents are already obsolete.
- Enhance the READMEs across all the examples.
- Update config for security-outbound example to add outbound entry so that the security context can properly be propagated from gRPC to Rest and vice-versa.
- Remove grpc.marshaller.java.enabled from the config as it is not used anymore.
- Replace policy with policy-validator as the former is an invalid ABAC attribute.
1. Add JavaMarshaller in the common library, load it using the Java Service Loader pattern by adding it in META-INF/services and modify MP/SE server/clients that require serialization on the gRPC request/response by setting it as the custom marshaller. 2. Update pom.xml for microservices example because the contents are alreadyobsolete. 3. Enhance the READMEs across all the examples. 4. Update config for security-outbound example to add outbound entry so that the security context can properly be propagated from gRPC to Rest and vice-versa. 5. Remove grpc.marshaller.java.enabled from the config as it is not used anymore. 6. Replace policy with policy-validator as the former is an invalid ABAC attribute.
|
This PR was created to fix GRPC examples are failing #4576 |
tomas-langer
previously requested changes
Jul 21, 2022
examples/grpc/common/src/main/java/io/helidon/grpc/examples/common/JavaMarshaller.java
Outdated
Show resolved
Hide resolved
klustria
dismissed
tomas-langer’s stale review
Review comments were already resolved. Need to merge so asked another reviewer (Arjav) to look.
klustria
added a commit
to klustria/helidon
that referenced
this pull request
Jul 29, 2022
1. Update pom.xml for microservices example because the contents are already obsolete. 2. Enhance the READMEs across all the examples. 3. Update config for security-outbound example to add outbound entry so that the security context can properly be propagated from gRPC to Rest and vice-versa. 4. Replace policy with policy-validator as the former is an invalid ABAC attribute.
klustria
added a commit
that referenced
this pull request
Jul 29, 2022
1. Update pom.xml for microservices example because the contents are already obsolete. 2. Enhance the READMEs across all the examples. 3. Update config for security-outbound example to add outbound entry so that the security context can properly be propagated from gRPC to Rest and vice-versa. 4. Replace policy with policy-validator as the former is an invalid ABAC attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.