Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC examples that are failing. #4585

Merged
merged 4 commits into from
Jul 21, 2022

Conversation

klustria
Copy link
Member

@klustria klustria commented Jul 21, 2022

  1. Use built-in JsobBMarshaller for the gRPC request/response that needs it by setting it as the custom marshaller.
  2. Update pom.xml for microservices example because the contents are already obsolete.
  3. Enhance the READMEs across all the examples.
  4. Update config for security-outbound example to add outbound entry so that the security context can properly be propagated from gRPC to Rest and vice-versa.
  5. Remove grpc.marshaller.java.enabled from the config as it is not used anymore.
  6. Replace policy with policy-validator as the former is an invalid ABAC attribute.

1. Add JavaMarshaller in the common library, load it using the Java Service Loader pattern by adding it in META-INF/services and modify MP/SE server/clients that require serialization on the gRPC request/response by setting it as the custom marshaller.
2. Update pom.xml for microservices example because the contents are alreadyobsolete.
3. Enhance the READMEs across all the examples.
4. Update config for security-outbound example to add outbound entry so that the security context can properly be propagated from gRPC to Rest and vice-versa.
5. Remove grpc.marshaller.java.enabled from the config as it is not used anymore.
6. Replace policy with policy-validator as the former is an invalid ABAC attribute.
@klustria klustria self-assigned this Jul 21, 2022
@klustria
Copy link
Member Author

klustria commented Jul 21, 2022

This PR was created to fix GRPC examples are failing #4576

Copy link
Member

@arjav-desai arjav-desai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klustria klustria dismissed tomas-langer’s stale review July 21, 2022 22:36

Review comments were already resolved. Need to merge so asked another reviewer (Arjav) to look.

@klustria klustria merged commit b43b1ce into helidon-io:master Jul 21, 2022
klustria added a commit to klustria/helidon that referenced this pull request Jul 29, 2022
1. Update pom.xml for microservices example because the contents are already obsolete.
2. Enhance the READMEs across all the examples.
3. Update config for security-outbound example to add outbound entry so that the security context can properly be propagated from gRPC to Rest and vice-versa.
4. Replace policy with policy-validator as the former is an invalid ABAC attribute.
klustria added a commit that referenced this pull request Jul 29, 2022
1. Update pom.xml for microservices example because the contents are already obsolete.
2. Enhance the READMEs across all the examples.
3. Update config for security-outbound example to add outbound entry so that the security context can properly be propagated from gRPC to Rest and vice-versa.
4. Replace policy with policy-validator as the former is an invalid ABAC attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants