Helidon DB Client #657
Merged
Helidon DB Client #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
force-pushed
the
581-helidon-db
branch
from
cfd5ad3
to
730dd2e
Compare
spericas
reviewed
May 8, 2019
common/mapper/src/main/java/io/helidon/common/mapper/Mapper.java
Outdated
Show resolved
Hide resolved
spericas
reviewed
May 8, 2019
db/common/src/main/java/io/helidon/db/common/MappingProcessor.java
Outdated
Show resolved
Hide resolved
spericas
reviewed
May 8, 2019
db/common/src/main/java/io/helidon/db/common/MappingProcessor.java
Outdated
Show resolved
Hide resolved
Tomas-Kraus
reviewed
May 14, 2019
There was a problem hiding this comment.
@tomas-langer Adding some notes for changes. Please check them and answer what you can. I can implement all of them myself when I'll have some free cycles.
db/jdbc/src/main/java/io/helidon/db/jdbc/JdbcStatementGeneric.java
Outdated
Show resolved
Hide resolved
db/jdbc/src/main/java/io/helidon/db/jdbc/JdbcStatementQuery.java
Outdated
Show resolved
Hide resolved
db/jdbc/src/main/java/io/helidon/db/jdbc/JdbcStatementQuery.java
Outdated
Show resolved
Hide resolved
db/jdbc/src/main/java/io/helidon/db/jdbc/JdbcStatementQuery.java
Outdated
Show resolved
Hide resolved
tomas-langer
force-pushed
the
581-helidon-db
branch
2 times, most recently
from
165cf8b
to
5f26982
Compare
tomas-langer
commented
Aug 5, 2019
common/configurable/src/main/java/io/helidon/common/configurable/LruCache.java
Show resolved
Hide resolved
tomas-langer
force-pushed
the
581-helidon-db
branch
from
73f8fac
to
f4d3825
Compare
Closed
Tomas-Kraus
force-pushed
the
581-helidon-db
branch
from
790aaa7
to
eca1408
Compare
Tomas-Kraus
force-pushed
the
581-helidon-db
branch
3 times, most recently
from
4f68f7a
to
6640bbf
Compare
tomas-langer
force-pushed
the
581-helidon-db
branch
2 times, most recently
from
18c9523
to
acd41d9
Compare
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com> Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
force-pushed
the
581-helidon-db
branch
from
acd41d9
to
274d87d
Compare
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
force-pushed
the
581-helidon-db
branch
from
9e87818
to
494e3f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API is now documented and in state to be reviewed (modules db/db and db/common).
The following modules are also documented and working:
db/health- health check supportdb/metrics- metrics interceptors with support for Config and ServiceLoaderdb/tracing- tracing interceptor with support for Config and ServiceLoaderOther modules are in a state of alpha:
db/jdbc - implementation over JDBC
db/jsonp - support for JSON-P when writing and reading from the database
db/mongodb - implementation over mongo reactive client
examples/db/jdbc - example using JDBC and interceptors configured in application.yaml
examples/db/mongodb - example using mongo and interceptors configured through builder