-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strerror_r on cygwin #138
Labels
Comments
Thanks @kubo |
anthony-tuininga
added a commit
that referenced
this issue
Jun 27, 2020
anthony-tuininga
added
the
patch available
Awaiting inclusion in official release
label
Jun 27, 2020
I've marked this for version 4.1 but if a patch release (4.0.2) is created I'll include it in there, too. |
Let me know if the creation of a patch release would be helpful to you, @kubo. |
anthony-tuininga
added a commit
that referenced
this issue
Aug 31, 2020
This was included in 4.0.2 released on August 31, 2020. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ODPI-C version: 4.0.1
OS: Cygwin on Windows
Compiler: gcc
Cygwin declares GNU-version strerror_r when
_GNU_SOURCE
is defined. However the POSIX version is used in the following code.No warnings by accident when compiling ODPI-C. That's because comparison with a pointer and literal zero is compilable without warnings.
When the above code is changed as follows,
gcc prints the following warning.
This implies that the strerror_r isn't the POSIX version returning
int
. It is the GNU version returningchar *
.The following code in place of
#if defined(__GLIBC__)
fixes the issue.The text was updated successfully, but these errors were encountered: