strncat bounds warnings with GCC8

[cemremengu]

Building ODPI-C version 2.4 on Windows 10 with gcc (x86_64-posix-seh-rev0, Built by MinGW-W64 project) 8.1.0, I am getting these warnings after the build. Looks like there are no problems with the build overall though.

In file included from go\src\github.com\go-goracle\goracle\odpi\embed/dpi.c:37,
                 from go\src\github.com\go-goracle\goracle\drv.go:48:
C:/Users/cemre.mengu/go/src/github.com/go-goracle/goracle/odpi/src/dpiOci.c: In function 'dpiOci__findAndCheckDllArchitecture':
C:/Users/cemre.mengu/go/src/github.com/go-goracle/goracle/odpi/src/dpiOci.c:1429:9: warning: 'strncat' specified bound 261 equals destination size [-Wstringop-overflow=]
         strncat(fullName, "\\", sizeof(fullName));
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function 'dpiOci__findAndCheckDllArchitecture.constprop',
    inlined from 'dpiOci__getLoadErrorOnWindows.constprop' at C:/Users/cemre.mengu/go/src/github.com/go-goracle/goracle/odpi/src/dpiOci.c:1483:13,
    inlined from 'dpiOci__loadLib' at C:/Users/cemre.mengu/go/src/github.com/go-goracle/goracle/odpi/src/dpiOci.c:1549:13: C:/Users/cemre.mengu/go/src/github.com/go-goracle/goracle/odpi/src/dpiOci.c:1421:13: warning: 'strncat' specified bound 261 equals destination size [-Wstringop-overflow=]
             strncat(fullName, dllName, sizeof(fullName));
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:/Users/cemre.mengu/go/src/github.com/go-goracle/goracle/odpi/src/dpiOci.c:1430:9: warning: 'strncat' specified bound 261 equals destination size [-Wstringop-overflow=]
         strncat(fullName, dllName, sizeof(fullName));
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[cjbj]

Off by one: "The strncat() function appends not more than n characters from s2, and then adds a terminating `\0'."

[anthony-tuininga]

@cemremengu, I just pushed a commit that should eliminate these warnings. Let me know if that is indeed the case. The only time you would have run into problems is when you were at exactly the maximum length -- very unlikely, but still worth fixing! Thanks for bringing it to our attention.

[cemremengu]

Yes, compiling goracle with the recent master no longer produces these warnings. Thanks for the quick fix! Feel free to close the issue whenever you like.