New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dropping of statement from cache for some errors #76

Closed
anthony-tuininga opened this Issue Nov 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@anthony-tuininga
Copy link
Member

anthony-tuininga commented Nov 2, 2018

Following on from issue #73,

And Btw. dpiStmt__execute function and performance. I found that all statements then returned error other than ORA-00001 get the deleteFromCache flag set. But for errors as 1400/1438/1461/2290/2291/2292/21525 one could also want not to drop the statements from OCI cache. Thought the "1" is the most common try&error case but similiar could apply to the other codes if application just tries the inserts/updates without previous validity checking and possibly deallocate the dpiStmt causing the deleteFromCache to apply before executing same statement with different values (which might not run into one of the errors).

I agree that these additional error codes should be added and the statement should not be removed from the cache if these errors occur. I'll add the code to make that happen.

anthony-tuininga added a commit that referenced this issue Nov 2, 2018

Additional errors (besides ORA-0001) should be exempted from the need…
… to drop

the statement from the cache since these errors are due to the data being
bound and not due to something in the statement itself
(#76).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment