Added a provider for GCP #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
psilberk
reviewed
Jun 24, 2024
psilberk
reviewed
Jun 24, 2024
ojdbc-provider-gcp/README.md
Outdated
| A sign-in screen appears. After you sign in, your credentials are stored in the local credential file used by ADC. | ||
|
|
||
| ## GCP Object Storage Config Provider | ||
| The Oracle DataSource uses a new prefix `jdbc:oracle:thin:@config-gcp-object:` to be able to identify that the configuration parameters should be loaded using GCP Object Storage. Users only need to indicate the project, bucket and object containing the JSON payload, with the following syntax: |
There was a problem hiding this comment.
I think it should be without the '-' (like config-ociobject), and config-gcpstorage (being the other one config-gcpsecret)
psilberk
reviewed
Jun 24, 2024
| * A provider for JSON payload which contains configuration from GCP Object | ||
| * Storage. See {@link #getJson(String)} for the spec of the JSON payload. | ||
| */ | ||
| public class GcpObjectStorageConfigurationProvider extends OracleConfigurationJsonProvider { |
There was a problem hiding this comment.
Same observation regarding the naming (in the readme) this should be GcpCloudStorage....
psilberk
reviewed
Jun 24, 2024
| * Manager. | ||
| * See {@link #getJson(String)} for the spec of the JSON payload. | ||
| **/ | ||
| public class GcpVaultSecretConfigurationProvider extends OracleConfigurationJsonProvider { |
There was a problem hiding this comment.
As in the readme, I think this one should be GcpSecretManagerConfiguratioProvider
psilberk
reviewed
Jun 24, 2024
| * A standalone example that configures Oracle JDBC to be provided with the | ||
| * connection properties retrieved from OCI Object Storage. | ||
| */ | ||
| public class SimpleObjectStorageExample { |
There was a problem hiding this comment.
Same observation with the name (CloudStorage), but the demo is perfect, thanks
psilberk
reviewed
Jun 24, 2024
| * A standalone example that configures Oracle JDBC to be provided with the | ||
| * connection properties retrieved from GCP Secret Manager. | ||
| */ | ||
| public class SimpleVaultJsonExample { |
psilberk
reviewed
Jun 24, 2024
...er-gcp/src/main/java/oracle/jdbc/provider/gcp/resource/GcpSecretManagerPasswordProvider.java
Outdated
Show resolved
Hide resolved
ojdbc-provider-gcp/src/main/java/oracle/jdbc/provider/gcp/secrets/GcpSecretManagerFactory.java
Outdated
Show resolved
Hide resolved
Michael-A-McMahon
previously approved these changes
Jul 3, 2024
.../main/java/oracle/jdbc/provider/gcp/configuration/GcpSecretManagerConfigurationProvider.java
Outdated
Show resolved
Hide resolved
README.md
Outdated
| contain providers for a particular cloud platform: | ||
| <dl> | ||
| <dt><a href="ojdbc-provider-oci/README.md">Oracle JDBC OCI Providers</a></dt> | ||
| <dd>Providers for integration with Oracle Cloud Infrastructure (OCI)</dd> | ||
| <dt><a href="ojdbc-provider-azure/README.md">Oracle JDBC Azure Providers</a></dt> | ||
| <dd>Providers for integration with Microsoft Azure</dd> | ||
| <dt><a href="ojdbc-provider-gdp/README.md">Oracle JDBC GCP Providers</a></dt> |
jeandelavarene
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project add the following providers for Google Cloud Platform:
This pull request also adds samples on how to use these providers.