-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Lua analyzer #1057
add Lua analyzer #1057
Conversation
comments are fun
Nice ! would it be possible to add some tests ? |
Sure. Let me see if I can whip up a representative Lua sample file. |
*/ | ||
|
||
/* | ||
* Get Golang symbols - ignores comments, strings, keywords |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get LUA sumbols? ;)
copy paste ? :-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah! I thought I grepped for all those. Guess not. 💃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grep? pff ... you should have used grok to find all of them! :-D
@3van any news? |
@3van confirming your OCA, so basically we're just waiting for you :) |
I haven't had time to work on this recently but I'll at least fix the typo and see if I can get some basic tests done this weekend. Thanks for verifying the OCA; that's good to know as well. |
@3van any news? :) I'd like to merge this, so we can move on, we can push tests with new pull req (divide and conquer) |
@3van I am just going to accept this, let's move the tests to a new pull req, I will fix the silly typos for you |
and thank you @3van ! :) |
Based off of the Lua 5.3 Reference Manual.
I ran it against our (crazy, massively large) codebase and didn't see it trip up on any of our Lua.
I signed the OCA forever ago when I used to contribute to the ndbcluster engine on MySQL; not sure if I need to sign anything else for this, but let me know if I do.